Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDisable variations service #1733
Open
Comments
pilgrim-brave
moved this from Untriaged Backlog
to P3, P4, & P5 Backlog
in Network Audit
|
@jumde Could you check whether this is already fixed? |
|
Not fixed yet, there are a couple of features using this service. Setting the estimate to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Service sends and receives information to Google servers periodically. According to https://cs.chromium.org/chromium/src/components/variations/service/variations_service.cc?l=232 it is only enabled for official Google Chrome builds, but there is also a command line switch to enable it.
At a minimum, we should ensure that the IFDEF for official Chrome builds is not being triggered, and also disable the command line switch.
As a defense-in-depth, we could also patch
VariationsService::DoFetchFromURLhttps://cs.chromium.org/chromium/src/components/variations/service/variations_service.cc?l=506 to ensure it never issues a network request.