Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match content setting rules to allow subdomain and port specifications #1775

Open
srirambv opened this issue Oct 22, 2018 · 5 comments
Open
Labels
feature/autoplay feature/global-settings Settings at browser level independent of shields settings priority/P4 Planned work. We expect to get to it "soon".

Comments

@srirambv
Copy link
Contributor

Description

Match content setting rules to allow subdomain and port specifications

Steps to Reproduce

  1. Settings -> Privacy -> Autoplay
  2. Add any of these combinations youtube.com / https://youtube.com / https://youtube.com:443 / `youtube.com:443
  3. Visit YouTube and click on a video, still starts to autoplay

Actual result:

Manually adding domain name to block list doesn't truly block autoplay

Expected result:

Should block autoplay even if the user just adds a domain name without https://www. prefix and :443 port number being specified

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes
  • Does it reproduce on browser-laptop?
    N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added good first issue feature/global-settings Settings at browser level independent of shields settings feature/autoplay labels Oct 22, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Oct 22, 2018
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 26, 2018
@jonk
Copy link

jonk commented Oct 27, 2018

I'll take a try at fixing this

@jonk
Copy link

jonk commented Nov 8, 2018

Running into some issues building and initializing brave locally, but still planning on working on this :)

@Brave-Matt
Copy link

These rules apply to Cookies --> Clear on exitas well when adding manually.
Entry must have https:// and :443 port number to work.

@bsclifton
Copy link
Member

@srirambv is this fixed now? I think it should work

@srirambv
Copy link
Contributor Author

Does seem to repro still

1775.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/autoplay feature/global-settings Settings at browser level independent of shields settings priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

5 participants