Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should be able to 'Claim' the grant from the BAT panel. #1783

Closed
jenn-rhim opened this issue Oct 22, 2018 · 1 comment · Fixed by brave/brave-core#1092
Closed

User should be able to 'Claim' the grant from the BAT panel. #1783

jenn-rhim opened this issue Oct 22, 2018 · 1 comment · Fixed by brave/brave-core#1092

Comments

@jenn-rhim
Copy link

jenn-rhim commented Oct 22, 2018

Description

On vs 0.55.19, received token grant notification. The button should be 'Claim' instead of 'OK'. And the claiming the grant should be done on the panel without user having to go to the Settings page.

In the current build:
screen shot 2018-10-22 at 3 56 50 pm

Expected:
screen shot 2018-10-22 at 4 00 42 pm

Click on the Claim button:
screen shot 2018-12-03 at 12 47 27 pm

Error:
screen shot 2018-12-03 at 12 47 31 pm

Success:
screen shot 2018-12-03 at 12 47 37 pm

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Oct 23, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.56.x - Beta Oct 23, 2018
@bbondy bbondy added this to Rewards in 0.56.x - Beta Oct 23, 2018
@rebron rebron added this to In progress in Rewards Oct 30, 2018
@NejcZdovc NejcZdovc moved this from In progress to Backlog in Rewards Oct 30, 2018
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@bbondy bbondy removed this from Rewards in 0.56.x - Beta Oct 30, 2018
@NejcZdovc NejcZdovc added the priority/P4 Planned work. We expect to get to it "soon". label Oct 30, 2018
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Rewards Oct 30, 2018
@NejcZdovc NejcZdovc removed their assignment Oct 31, 2018
@NejcZdovc NejcZdovc added this to Ryan in Rewards Team Dec 3, 2018
@NejcZdovc NejcZdovc moved this from P3, P4, & P5 Backlog to In Progress in Rewards Dec 18, 2018
Rewards automation moved this from In Progress to Completed Dec 19, 2018
Rewards Team automation moved this from Ryan to Closed Dec 19, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 19, 2018
@NejcZdovc NejcZdovc moved this from Completed to Waiting uplift in Rewards Jan 8, 2019
@NejcZdovc NejcZdovc modified the milestones: 0.60.x - Dev, 0.59.x - Beta Jan 14, 2019
@NejcZdovc NejcZdovc moved this from Waiting uplift to Completed in Rewards Jan 14, 2019
@btlechowski
Copy link
Collaborator

btlechowski commented Jan 18, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Used test plan from brave/brave-core#1092 and did some exploratory testing
Experienced #2959 and #2956
image

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux

screenshot from 2019-01-18 17-15-37
screenshot from 2019-01-18 17-16-28

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

8 participants