Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave components are re-downloaded to create profile folder when trying to uninstall #1812

Open
srirambv opened this issue Oct 23, 2018 · 1 comment

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 23, 2018

Description

Brave components are re-downloaded to create profile folder when trying to uninstall

Steps to Reproduce

  1. Rename browser profile to %userprofile%/Appdata/Local/BraveSoftware_Old/ and keep the local profile folder open
  2. Open Settings-> App-> Brave -> Uninstall
  3. Creates a browser profile and downloads Brave components
  4. Folder remains if user doesn't uncheck Remove user profile data from the uninstaller

Actual result:

profile

Expected result:

Should not recreate the profile folder when no profile folder exists

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @simonhong @bbondy

@srirambv srirambv added this to the 1.x Backlog milestone Oct 23, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@vdhanan
Copy link

@vdhanan vdhanan commented Aug 5, 2019

I noticed this issue has a good first bug label. Has it been resolved? If not, I would like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.