Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Assets Missing from Crypto Wallets #18810

Closed
jonathansampson opened this issue Oct 16, 2021 · 2 comments · Fixed by brave/ethereum-remote-client#279
Closed

Media Assets Missing from Crypto Wallets #18810

jonathansampson opened this issue Oct 16, 2021 · 2 comments · Fixed by brave/ethereum-remote-client#279

Comments

@jonathansampson
Copy link
Contributor

Description

Some image assets are missing from the Crypto Wallets repo (e.g. ./app/images/icons/connected-sites.svg) which creates noticeable UI issues.

image

Many appear to have been removed by brave/ethereum-remote-client#172.

Brave version (brave://version info)

1.30.89

@jonathansampson jonathansampson added bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Oct 16, 2021
jonathansampson added a commit to brave/ethereum-remote-client that referenced this issue Oct 16, 2021
Partially (or completely) resolves brave/brave-browser#18810
@jonathansampson
Copy link
Contributor Author

I did some cursory scanning around the interface, and this was the only image I found to be missing. Opened a PR to restore the graphic at brave/ethereum-remote-client#279.

@bbondy bbondy added this to the Ethereum Remote Client v1.0.37 milestone Oct 19, 2021
@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Jan 7, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jan 7, 2022

Added QA/No after speaking with @srirambv 👍

@kjozwiak kjozwiak removed this from the Ethereum Remote Client v1.0.37 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants