New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detecting creator info (including verification status) requires tab reload or switching away and back into tab #19650
Comments
@Miyayes Do you have a semi-reliable repro for this? I'm having trouble making it happen now. |
I can't seem to repro this either.
in logs (which means that |
@szilardszaloki where do I look to share the logs you needed to see? I know recently we've had people such as https://www.youtube.com/user/crownrahulmehra who mentioned. When I clicked on that link, it showed as YouTube.com with unverified creator. Yet when I clicked on Videos or somehow navigated within, it suddenly showed Pure Gaming as Verified Creator. There's been plenty of others, but it's trying to figure out why it's not populating. The main time I see this reproduce is when clicking on links that take us directly to their pages. Whether it be on Reddit or YouTube. Yet once we navigate further, it falls in place as it should. I'm confident I can reproduce it myself as I just did it yet again a moment ago. Big issue is the only Logs I'm aware of is at brave://rewards-internals and I don't see it there. If I know where to look to let you know what is changing, I'll post for you. |
@Saoiray If you're still able to repro this issue, please press Ctrl+Shift+I (or equivalent) to bring up DevTools, switch to the "Console" tab, and please paste any messages here as long as they don't contain any sensitive information. Thanks! |
Some potentially helpful investigation from a user:
From: #14986 (comment) // cc: @emerick |
Hey, I've noticed this behaviour with YouTube for sometime now as well - it seems to only happen with YouTube. To fix it I usually open the Brave Rewards drop down GUI once or twice, refresh the page, go back and forward e.t.c. Brave then usually picks up and shows what channel you're viewing (in the drop down GUI), and if they're verified (by showing the blue tick beside the Brave Rewards icon and under their name in the drop down GUI). The bugged behaviour reappears after closing Brave. Also, the little blue tick not displaying on any website is still happening (with my configuration of Brave Rewards enabled, and Auto-Contribute disabled as mentioned in the above comment). Clicking the BAT/Brave Rewards icon, then refreshing the tab, fixes the issue while Brave remains open. It resets to the previous behaviour after closing Brave. Hope this helps! |
Looks to be fixed with the latest update. Also, the little blue tick is now showing with the Brave Rewards enabled, and Auto-Contribute disabled - thanks! |
@emerick This was recently brought up by someone again but only on Android. https://community.brave.com/t/twitch-account-is-showing-as-unverified-in-mobile/432877 Link to their creator content is https://www.twitch.tv/lego11as If open on Desktop, it shows them as a Verified Creator. When that same site is visited on Android, it only shows as Twitch rather than the Creator and, as a result, shows Twitch as the Unverified Creator. Didn't matter if I refreshed, different page/tab of their Twitch, if opened in Private tab, or anything. I even went to the hamburger menu and toggled Desktop Mode, but that didn't resolve. Then on Desktop, typed in mobile address. https://m.twitch.tv/lego11as/home
I kind of wish I knew how to do the equivalent on Android. When I tried with Eruda, the Console was blank. I tested on a Samsung Galaxy S9 running Android 10. Brave version 1.43.93. |
I think this is just because Twitch is not yet supported on Android. |
Yeah, I've learned it's intentional. I didn't ever pay attention to tipping on Android. Uncertain why we don't allow tipping to people on Reddit, Twitter, or Twitch from Android and that it's a Desktop only thing for the moment. Not sure whose idea that is or even when it will be adjusted so tipping works on all platforms. But I guess that's going to be a different issue. |
@Saoiray In short, answer is that we don't have GreaseLion on Android yet. Once we get GreaseLion on Android (though it may be awhile), then we can easily add more platform support for tipping. |
Difficult to reproduce. Haven't seen it as much recently. |
Description
Often, when visiting a new channel, the creator info will not be picked up by the Rewards panel, and for verified channels, no blue checkmark will appear over the BAT icon in the URL bar either. Even after 10 seconds or so and after closing and reopening the panel, the creator info will not be populated. (For example, if a YouTube channel, it might just show youtube.com.)
However, if you refresh the tab, or perhaps switch to another tab and back, then the panel will start to detect and parse the creator info quickly (e.g., within a second).
@emerick has observed this before as well.
The text was updated successfully, but these errors were encountered: