Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchased content from youtube doesn't prompt to install Widevine (Amazon too) #1985

Closed
bbondy opened this Issue Nov 4, 2018 · 5 comments

Comments

@bbondy
Copy link
Member

bbondy commented Nov 4, 2018

Description

A user from Twitter reports that purchased content doesn't prompt to install Widevine.

Widevine currently only prompts to install based on URL pattern:

https://github.com/brave/brave-core/blob/a57dc16dba02ea52adcca39a5189533e15168752/common/shield_exceptions.cc#L127
But we don't want to prompt for all of youtube.com for Widevine.

So we'd need a content script or some kind of network filter or other detection mechanism.

If Widevine is already installed, it does play.

Steps to Reproduce

I haven't tried these steps yet, but I think they would be:

  1. Go to in a new profile https://www.youtube.com/watch?v=RQn-Pqvnzc8
  2. Purchase it

Actual result:

Video doesn't play
screen shot 2018-11-28 at 12 38 58 pm

Expected result:

It prompts to install Widevine in the URL bar. Clicking the prompt should make the video play.

Reproduces how often:

Always, as long as Widevine is not installed.

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No

@bbondy bbondy added this to the 1.x Backlog milestone Nov 4, 2018

@srirambv

This comment has been minimized.

Copy link
Collaborator

srirambv commented Nov 5, 2018

There is also an issue on Spotify & Amazon.de where users don't get prompt for Widevine to play prime videos, but works on primevideo.com

https://community.brave.com/t/how-do-i-enable-widevine-in-beta-when-the-browser-does-not-prompt/36739/2?u=sriram

@rebron rebron added this to Untriaged Backlog in General Nov 5, 2018

@bbondy bbondy changed the title Purchased content from youtube doesn't prompt to install Widevine Purchased content from youtube doesn't prompt to install Widevine (Amazon too) Nov 6, 2018

@bbondy bbondy referenced this issue Nov 6, 2018

Merged

Support Widevine and 2 component updaters #189

5 of 9 tasks complete

@rebron rebron moved this from Untriaged Backlog to P1 & P2 Backlog in General Nov 6, 2018

@iefremov iefremov self-assigned this Nov 19, 2018

@eljuno

This comment has been minimized.

@karenkliu

This comment has been minimized.

Copy link
Collaborator

karenkliu commented Nov 29, 2018

+1 here too

iefremov added a commit to brave/brave-core that referenced this issue Dec 6, 2018

Issue 1985: Properly show the widevine absence prompt.
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls wih a blink hook and a corresponding
tab helper that updates the widevine content settings icon.

iefremov added a commit to brave/brave-core that referenced this issue Dec 6, 2018

Issue 1985: Properly show the widevine absence prompt.
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.

iefremov added a commit to brave/brave-core that referenced this issue Dec 6, 2018

Issue 1985: Properly show the widevine absence prompt.
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.

iefremov added a commit to brave/brave-core that referenced this issue Dec 6, 2018

Issue 1985: Properly show the widevine absence prompt.
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.

iefremov added a commit to brave/brave-core that referenced this issue Dec 6, 2018

Issue 1985: Properly show the widevine absence prompt.
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.

bbondy added a commit to brave/brave-core that referenced this issue Dec 10, 2018

Issue 1985: Properly show the widevine absence prompt.
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.

iefremov added a commit to brave/brave-core that referenced this issue Dec 12, 2018

Issue 1985: Properly show the widevine absence prompt.
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.

bbondy added a commit to brave/brave-core that referenced this issue Dec 12, 2018

Issue 1985: Properly show the widevine absence prompt.
Fixes brave/brave-browser#1985
Replacing a set of hardcoded urls with a blink hook and a corresponding
tab helper that updates the widevine content settings icon.

General automation moved this from P1 & P2 Backlog to Completed Dec 14, 2018

@bbondy bbondy modified the milestones: 1.x Backlog, 0.59.x - Beta Dec 14, 2018

@rebron rebron removed this from Completed in General Dec 28, 2018

@kjozwiak

This comment has been minimized.

Copy link
Member

kjozwiak commented Jan 23, 2019

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X
  • ensured that I received the Widevine notification on Netflix, YouTube and Amazon Prime Video

Amazon Prime Video -- PASSED

screen shot 2019-01-23 at 4 43 32 pm

Netflix -- PASSED

screen shot 2019-01-23 at 5 09 07 pm

YouTube -- PASSED

screen shot 2019-01-23 at 5 12 03 pm

Verification passed on

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows

[PASS] Amazon Prime Video
image

[PASS] Netflix
image

[PASS] youtube
image

@srirambv

This comment has been minimized.

Copy link
Collaborator

srirambv commented Jan 24, 2019

Marking issue as Windows/macOS only as Linux doesn't support Widevine (yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.