Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate ad block #2

Closed
bbondy opened this issue Nov 10, 2017 · 2 comments
Closed

Integrate ad block #2

bbondy opened this issue Nov 10, 2017 · 2 comments
Assignees
@bbondy
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Nov 10, 2017

No description provided.

@bbondy bbondy self-assigned this Nov 10, 2017
@bbondy bbondy changed the title Integrate adblock Integrate ad block Dec 5, 2017
@bbondy bbondy added this to the Milestone 1: Open Source milestone Dec 5, 2017
@bbondy
Copy link
Member Author

@bbondy bbondy commented Dec 19, 2017

This landed, so closing.
@bbondy bbondy closed this Dec 19, 2017
@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Releasable builds Jun 13, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 20, 2018 •
edited by kjozwiak

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
@kjozwiak kjozwiak added QA Pass-macOS and removed QA/Yes labels Sep 25, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
@bbondy bbondy mentioned this issue Oct 20, 2018
Closed
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Nov 21, 2018
Closed
@rebron rebron mentioned this issue May 28, 2019
Closed
@dlewand691 dlewand691 mentioned this issue Aug 30, 2019
Closed
mbacchi added a commit that referenced this issue Sep 4, 2019
@mbacchi
Use shorter workspace on Windows CI builds (attempt #2)
Verified
This commit was signed with a verified signature.
mbacchi Matt Bacchi
GPG key ID: 9009221AE2C5ED52 Learn about signing commits
8b23fa6
mbacchi added a commit that referenced this issue Sep 6, 2019
@mbacchi
Use shorter workspace on Windows CI builds (attempt #2)
f07776a
mbacchi added a commit that referenced this issue Sep 6, 2019
@mbacchi
Use shorter workspace on Windows CI builds (attempt #2)
Loading status checks…
62b11d6 
Correct string concatenation

Wrap agent parameters in node block
mbacchi added a commit that referenced this issue Sep 6, 2019
@mbacchi
Merge pull request #5897 from brave/customworkspace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
c91c6c8 
Use shorter workspace on Windows CI builds (attempt #2)
mkarolin added a commit that referenced this issue Sep 10, 2019
@mbacchi @mkarolin
Use shorter workspace on Windows CI builds (attempt #2)
Loading status checks…
de10678 
Correct string concatenation

Wrap agent parameters in node block
bsclifton added a commit that referenced this issue Sep 11, 2019
@mbacchi @bsclifton
Use shorter workspace on Windows CI builds (attempt #2)
Verified
This commit was signed with a verified signature.
bsclifton Brian Clifton
GPG key ID: 50ED18CA5C4C0F73 Learn about signing commits
604a9a6 
Correct string concatenation

Wrap agent parameters in node block
mkarolin added a commit that referenced this issue Sep 11, 2019
@mbacchi @mkarolin
Use shorter workspace on Windows CI builds (attempt #2)
Loading status checks…
cb83cdd 
Correct string concatenation

Wrap agent parameters in node block
mkarolin added a commit that referenced this issue Sep 14, 2019
@mbacchi @mkarolin
Use shorter workspace on Windows CI builds (attempt #2)
Loading status checks…
0ded624 
Correct string concatenation

Wrap agent parameters in node block
mkarolin added a commit that referenced this issue Sep 15, 2019
@mbacchi @mkarolin
Use shorter workspace on Windows CI builds (attempt #2)
e495d7f 
Correct string concatenation

Wrap agent parameters in node block
bsclifton added a commit that referenced this issue Sep 17, 2019
@mbacchi @bsclifton
Use shorter workspace on Windows CI builds (attempt #2)
Verified
This commit was signed with a verified signature.
bsclifton Brian Clifton
GPG key ID: 50ED18CA5C4C0F73 Learn about signing commits
815bbfc 
Correct string concatenation

Wrap agent parameters in node block
@jstefani jstefani mentioned this issue Oct 8, 2019
Closed
@rebron rebron mentioned this issue Apr 16, 2020
Open
0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@bbondy @kjozwiak @srirambv @btlechowski
You can’t perform that action at this time.