Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on window caused by unique_ptr #2044

Closed
yrliou opened this issue Nov 8, 2018 · 1 comment
Closed

Build error on window caused by unique_ptr #2044

yrliou opened this issue Nov 8, 2018 · 1 comment

Comments

@yrliou
Copy link
Member

@yrliou yrliou commented Nov 8, 2018

In file included from ../../brave/vendor/bat-native-ledger/src/bat_state.cc:5:
../../brave/vendor/bat-native-ledger/src/bat_state.h(140,8):  error: no template                                                    named 'unique_ptr' in namespace 'std'
  std::unique_ptr<braveledger_bat_helper::CLIENT_STATE_ST> state_;
  ~~~~~^
../../brave/vendor/bat-native-ledger/src/bat_state.h(140,60):  error: private fi                                                   eld 'state_' is not used [-Werror,-Wunused-private-field]
  std::unique_ptr<braveledger_bat_helper::CLIENT_STATE_ST> state_;
                                                           ^
2 errors generated.

This is introduced by brave-intl/bat-native-ledger#171, so should be in the same milestone as #1997

@yrliou yrliou added the QA/No label Nov 8, 2018
@yrliou yrliou self-assigned this Nov 8, 2018
@NejcZdovc NejcZdovc added this to the 0.58.x - Dev milestone Nov 8, 2018
@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Nov 8, 2018
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to Waiting uplift in Rewards Nov 8, 2018
@bbondy bbondy modified the milestones: 0.58.x - Dev, 0.57.x - Beta Nov 28, 2018
@bbondy
Copy link
Member

@bbondy bbondy commented Nov 28, 2018

Adjusting milestone after it was uplifted to 0.57.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.