Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In page translation for content #208

Closed
bsclifton opened this issue May 17, 2018 · 87 comments
Closed

In page translation for content #208

bsclifton opened this issue May 17, 2018 · 87 comments

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented May 17, 2018

Similar to what is offered in Chrome:
screen shot 2018-05-17 at 1 56 32 pm

  • foreign language detected
  • small message box shown asking if user would like translation
  • button remains in place in URL bar (in case message box is dismissed)

Per #237, you should also be able to trigger this process by right clicking on the page and pick Translate from the context menu

@bsclifton bsclifton changed the title In page translation In page translation for content May 17, 2018
@bsclifton bsclifton added the l10n label May 17, 2018
@bbondy bbondy added this to Backlog in 0.55.x - Release Jun 6, 2018
@bbondy bbondy added this to the Backlog milestone Jun 6, 2018
@Naigel56
Copy link

@Naigel56 Naigel56 commented Aug 17, 2018

I want to strongly back this addition. How many of us nowadays are living/working abroad for extensive periods of time? It's really hard to read any non-english local business website (or "non-your-native-language") without any kind of translate plugin. Not to mention the possibility to read some foreign language articles, having an invaluable help while learning a foreign language, and so on.

I like Brave browser but personally this single missing feature is what refrain me from completely dropping Chrome.

@AvraamMavridis
Copy link

@AvraamMavridis AvraamMavridis commented Aug 17, 2018

Exactly @Naigel56

I keep reopening Chrome because I live in Germany and I don't speak the language.
Any time I want to read an email from a german service I have to open Chrome...

@bsclifton
Copy link
Member Author

@bsclifton bsclifton commented Sep 14, 2018

+1 from @srirambv via #237
The popup is presented, but when you click Translate it presents a The page could not be translated message

translate

@iMartyn
Copy link

@iMartyn iMartyn commented Oct 1, 2018

+1 another vote for this, living in a country who's primary language is not my own and the frustrating web devs who believe that location == language.

@Brave-Matt
Copy link
Collaborator

@Brave-Matt Brave-Matt commented Oct 8, 2018

@eljuno
Copy link

@eljuno eljuno commented Oct 25, 2018

+1 from community https://community.brave.com/t/right-click-translate-to-english-does-not-work/35663?u=eljuno

Version 0.55.18 Chromium: 70.0.3538.67 (Official Build) (64-bit)
English interface
Windows 10 Pro English v1803

Right click > Translate to _language_ not working > Nothing happens

+1 from Community https://community.brave.com/t/traduzione-nuove-pagine/42887?u=eljuno

+1 from Community https://community.brave.com/t/translator-option-not-working/43256?u=eljuno

@sadiqevani
Copy link

@sadiqevani sadiqevani commented Oct 29, 2018

+1 this would be awesome to have!

@cbatub
Copy link

@cbatub cbatub commented Nov 6, 2018

+1 please guys please please please fix it, fix it and Brave is close to perfect.

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Nov 6, 2018

cc @mandar-brave @davidtemkin @bbondy for prioritisation

@Th3-A6add0n
Copy link

@Th3-A6add0n Th3-A6add0n commented Nov 23, 2018

+1 from @srirambv via #237
The popup is presented, but when you click Translate it presents a The page could not be translated message

translate

This is not working, I've to use Google Translator Extention

@ArisAmp
Copy link

@ArisAmp ArisAmp commented Nov 26, 2018

+1 Right click -> Translate is a plugin to take the browser to the next level.

-For those who want to do that with a plugin, Mate Translate extension works perfectly good for my Brave Browser

@juanguren
Copy link

@juanguren juanguren commented Dec 6, 2018

Hey guys, what´s the current status on this plugin/option?

@ArisAmp
Copy link

@ArisAmp ArisAmp commented Dec 13, 2018

+1
Nothing happens when I click on translate

You need to download and crack mate translate. After install it you can use its plugin to translate pages in Brave Browser

@dwinnert
Copy link

@dwinnert dwinnert commented Dec 19, 2018

+1
Nothing happens when I click on translate

You need to download and crack mate translate. After install it you can use its plugin to translate pages in Brave Browser

Mate Translate does not work well. Many pages I go to Mate will only translate menus and not the body. Highlighting text and translate sucks.

Firefox also has the same issue as Brave in not having a native translator. I use this in Firefox and it works great. Maybe it could be ported over.....

https://github.com/andreicristianpetcu/google_translate_this

@hex0cter
Copy link

@hex0cter hex0cter commented Jan 6, 2019

+1

@2635599
Copy link

@2635599 2635599 commented Jan 6, 2019

"I want to strongly back this addition. How many of us nowadays are living/working abroad for extensive periods of time? It's really hard to read any non-english local business website (or "non-your-native-language") without any kind of translate plugin. Not to mention the possibility to read some foreign language articles, having an invaluable help while learning a foreign language, and so on.

I like Brave browser but personally this single missing feature is what refrain me from completely dropping Chrome"

yes the builtin translate featire needs to be added back in. there was no real reason to remove it. brave is fast, responsive, crisp and clean looking, but make no mistake it has faults. the above being one, adding your would ad blocker without anyway to universally turn it off, adding rewards without a way to completely turn it off. the last two as far as i'm concerned are uncompleted features added.

@steferr
Copy link

@steferr steferr commented Jan 17, 2019

+1

@megalithic
Copy link

@megalithic megalithic commented Jan 22, 2019

i find myself needing this more and more..

+1

@hex0cter
Copy link

@hex0cter hex0cter commented Jan 22, 2019

Please enable this feature!
+1

@2635599

This comment was marked as off-topic.

@wout
Copy link

@wout wout commented Oct 4, 2019

@simrobin Thank you so much for pointing that out. 🎉 I barely noticed the Language dropdown.

@wout
Copy link

@wout wout commented Oct 4, 2019

@2635599 I live in Europe and regularly visit sites in English, Spanish, Dutch, German and French, all languages I can read very well. If a pop-up appears on every other page you visit, and you can not find how to disable it within a few clicks, you get annoyed.

Feature request:
Provide an option to disable the “Install google translate” pop-up. Something similar to: “Never offer to install this plugin”.

@rickdsanchez
Copy link

@rickdsanchez rickdsanchez commented Oct 4, 2019

I would echo the suggestion by @wout

The recent update made Brave very non-friendly to people who speak several languages. The pop-up appears every single time even on the pages that one visited before.

Is there any way to disable this pop-up?

EDIT: It appears that there is a way to disable it on the per-language basis in the "Language" menu in the "Settings". I wonder if it makes sense to have a global "disable translations" checkbox in that pop-up?

@git10135405
Copy link

@git10135405 git10135405 commented Oct 9, 2019

The Google Translate plugin was unable to translate the page and reported an error:
Refused to load the script 'https://translate.google.com/translate_a/element.js?cb=TECB_1E07F158C6FA4460B352973E9693B329&client=tee&hl=zh-CN' because it violates the following Content Security Policy directive: "script-src github.githubassets.com". Note that 'script-src-elem' was not explicitly set, so 'script-src' is used as a fallback.

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Oct 9, 2019

The Google Translate plugin was unable to translate the page and reported an error

Mind sharing which page you were browsing when you hit the above issue?

@git10135405
Copy link

@git10135405 git10135405 commented Oct 9, 2019

The Google Translate plugin was unable to translate the page and reported an error

Mind sharing which page you were browsing when you hit the above issue?

#208

@GiacomoK
Copy link

@GiacomoK GiacomoK commented Oct 9, 2019

I would echo the suggestion by @wout

The recent update made Brave very non-friendly to people who speak several languages. The pop-up appears every single time even on the pages that one visited before.

Is there any way to disable this pop-up?

EDIT: It appears that there is a way to disable it on the per-language basis in the "Language" menu in the "Settings". I wonder if it makes sense to have a global "disable translations" checkbox in that pop-up?

You right, I have the same problem. It is very annoying to have popup message any single page loading.

@manishmaharjan
Copy link

@manishmaharjan manishmaharjan commented Oct 9, 2019

@rebron, Could you throw us a status update on this feature? Did you guys already find any translation providers for releasing this feature? Thank you :)

@rebron
Copy link
Collaborator

@rebron rebron commented Oct 9, 2019

@manishmaharjan
Per the original issue #208 (comment) we are matching Chrome behavior by offering the Google Translate extension to achieve translation parity though we will continue to evaluate translation partners. We did implement this feature sans extension with Microsoft translation services in Nightly/Dev/Beta but weren't able to proceed with them as a service provider.

We can probably close this one out and create a new one when we do move to different translation provider or model for providing the translation service.

We're also updating the dialog so users have a clearer way to don't show the dialog again. That's captured here: #6340

@git10135405
Copy link

@git10135405 git10135405 commented Oct 10, 2019

@manishmaharjan
Copy link

@manishmaharjan manishmaharjan commented Oct 10, 2019

@rebron , Thanks for providing some updates. Since this feature was never released in my opinion closing this issue doesn't sound like a good idea as an almost complete feature has already been implemented based on this issue.

Please also note that using google translation plugin would not be a viable solution as using as core functionality. For instance, in the mobile device it is still not able to provide translation features.

Since it has been more than a year, how likely brave would find translation provider? What is the biggest bottleneck on having Google/Microsoft as a translation provider? Is it a cost or something else is blocking from having them as a translation partner?

@pfuhrmann
Copy link

@pfuhrmann pfuhrmann commented Oct 10, 2019

Honestly, watching this issue over the past year, there is a minuscule chance that they will ever find a suitable provider. I commented on the same already back in June.

See my comments above about possible solutions with microtransactions that didn't receive any response from the developers. Brave is great browser and I wish I could use it, but sadly, this is a dealbreaker for me and for many others.

@ultrasound1372
Copy link

@ultrasound1372 ultrasound1372 commented Oct 13, 2019

I tried to use the google translation extension but it isn't seeming to work, trying to translate the page https://ux.getuploader.com/foobar2000/ as an example page in Japanese. Trying to translate uploader.jp, just in case the tld mattered, also didn't work. Says it has access, when I click it it pops up a box with an edit field, a translate button, and a translate the page link. Click the link, dismiss the box, nothing happens.

@w4cky
Copy link

@w4cky w4cky commented Oct 15, 2019

Hey guys, what´s the current status on this options?

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Oct 15, 2019

@w4cky translation is available from 0.69.x onwards. When you visit a page that is not in English you should be prompted to install the translation extension. This was implemented as part of #5561

@bsclifton we should consider closing this in favour of #5561 ?

@w4cky
Copy link

@w4cky w4cky commented Oct 15, 2019

@srirambv Google chrome does it more conveniently because it immediately translates the page in its window.

@manishmaharjan
Copy link

@manishmaharjan manishmaharjan commented Oct 15, 2019

@rebron , Thanks for providing some updates. Since this feature was never released in my opinion closing this issue doesn't sound like a good idea as an almost complete feature has already been implemented based on this issue.

Please also note that using google translation plugin would not be a viable solution as using as core functionality. For instance, in the mobile device it is still not able to provide translation features.

Since it has been more than a year, how likely brave would find translation provider? What is the biggest bottleneck on having Google/Microsoft as a translation provider? Is it a cost or something else is blocking from having them as a translation partner?

@srirambv , because of some of these core underlying issues, what would be the point of closing this issue when the main work done has been never released.

@rebron
Copy link
Collaborator

@rebron rebron commented Oct 16, 2019

Closing since original issue as described was completed with #5561 and shipped with 69.x. Please file separate issues for feature enhancements (additional or other translation providers), suggestions, or bugs with the current implementation.

@manishmaharjan
Copy link

@manishmaharjan manishmaharjan commented Oct 16, 2019

@rebron , that was a complete unprofessional move. You even failed to answer aforementioned question, but instead just decided to close this issue straightly. If brave as a company wants to just close the issue without addressing the core issue first then there might be a lot of question about a trust.

Moreover, awesome work done by @yrliou as part of releasing this feature is also lost.

Closing this issue means that this might never hit to release version now. There might not have any better ways to track this core underlying issues unless Brave wants to admit that this core feature would not be released to end customer as part of the core feature.

If Brave have clear intension of releasing this as a core feature then we would highly suggest that please keep this issue in an open state and have some milestone for releasing. This is a major feature that a lot of people are expecting. Hope Brave would decide the right thing.
Thanks

CC. @bbondy @bsclifton

@bsclifton
Copy link
Member Author

@bsclifton bsclifton commented Oct 16, 2019

Hi there @manishmaharjan

  • I personally believe the overall feature request in this issue has been addressed 👍 which is why this issue is closed
  • You are correct - the solution chosen to address this is NOT a directly comparable experience to what is in Chrome, unfortunately
    • We could have done a better job explaining why we chose this route
    • Chrome translates it in page (which @w4cky mentions is more convenient)
    • The work @yrliou did is great and I would like to see it used too
    • Cost is an issue though, which is why we changed course. These translation calls use a token which charges per-translation call (whether we use Google, Microsoft, or another provider)
    • What @pfuhrmann proposed with micro-transactions (to offset cost) is definitely interesting, but we should capture that overall proposal (ex: being able to chip in on service calls which have a cost using BAT) in it's own issue not related to translations (I can help flag the appropriate folks if you wanted to create an issue and expand on that, @pfuhrmann)
  • We can create a new issue to track the request of a directly comparable translate feature. I'm more than happy to create this. However, it's not on our roadmap as a company (at least, at the moment) to implement, because of cost. So while we can have an issue to track it, it would be open perpetually (until something changes).
@rebron
Copy link
Collaborator

@rebron rebron commented Oct 17, 2019

@manishmaharjan Sorry about closing the issue without answering your questions, I think @bsclifton replies answered them though. I closed this issue out because the feature request has been addressed and we're not doing any additional work within this issue, we're not discussing designs, implementation details, or creating prs attached to this issue any longer.

As we've done with other features/feature requests/enhancements, we can create specific and actionable issues that we can better address to move the feature along. Again, sorry for the lack of clarity.

@ultrasound1372
Copy link

@ultrasound1372 ultrasound1372 commented Oct 17, 2019

It prompted me to install the extension. I'm fine with that. But I couldn't actually, translate the page. It just stayed in its original language. Is it because I'm using a screen reader?

@marie228
Copy link

@marie228 marie228 commented Dec 5, 2019

Hi, there are so many posts on this subject, I'm a little lost.
If the option is available with version 1.0.1 Chromium: 78.0.3904.108 (Official Build) (64-bit), where can I find it and how to activate it?
Thanks! ,-)

@serial02
Copy link

@serial02 serial02 commented Feb 22, 2020

Hello Team @brave-browser-releases

There is a prediction when the Brave automatic translator will be working normally. Here in the Linux version it doesn't work as it can be seen in the image below:

https://imgur.com/O95bDXO

O95bDXO

@crogonint
Copy link

@crogonint crogonint commented Mar 29, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

You can’t perform that action at this time.