New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excluding sites via x sometimes results in one single site having a huge % value #2086

Open
LaurenWags opened this Issue Nov 10, 2018 · 8 comments

Comments

9 participants
@LaurenWags
Copy link
Collaborator

LaurenWags commented Nov 10, 2018

Description

I tried removing some sites via the x icon in popup which displays the full list of auto contribute sites, and I noticed that sometimes one of my sites gets displayed with a crazy huge percentage.

Steps to Reproduce

  1. Visit a bunch of non-YouTube sites.
  2. Watch a playlist on YouTube with a bunch of videos (this was primarily to increase the number of sites in my auto contribute table quickly, I currently have almost 100).
  3. Once you get to almost 100 sites, open brave://rewards (keep playlist running in background)
  4. Open the popup showing all auto-contribute sites
  5. Start deleting some of the sites with 0%

Actual result:

See that a site shows up at the bottom with a crazy huge percentage value which changes (probably because the playlist is still running in the background)

screen shot 2018-11-09 at 7 27 23 pm

Expected result:

No site should have that large of a % value

Reproduces how often:

Unsure

Brave version (brave://version info)

Brave 0.56.12 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? unsure

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

This was also reported on community but with some different steps:
https://community.brave.com/t/cannot-exclude-website-from-brave-rewards/36708/10

@LaurenWags LaurenWags added this to Untriaged Backlog in Rewards via automation Nov 10, 2018

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Nov 10, 2018

@Brave-Matt

This comment has been minimized.

Copy link
Collaborator

Brave-Matt commented Nov 14, 2018

@rebron rebron added the priority/P3 label Nov 16, 2018

@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Rewards Nov 19, 2018

@Brave-Matt

This comment has been minimized.

Copy link
Collaborator

Brave-Matt commented Nov 27, 2018

@ryanml

This comment has been minimized.

Copy link
Member

ryanml commented Dec 5, 2018

Spent some time today trying to reproduce on master, and was unable. Will give it another shot but if STR can change in any way to help better find the expected result that'd be great

cc: @NejcZdovc

@NejcZdovc NejcZdovc removed this from Ryan in Rewards Team Dec 5, 2018

@NejcZdovc NejcZdovc moved this from P3, P4, & P5 Backlog to Need investigation/Suggestions in Rewards Dec 5, 2018

@LaurenWags

This comment has been minimized.

Copy link
Collaborator Author

LaurenWags commented Dec 5, 2018

@ryanml the only real direction I have is that it seems to be related to upgraded profiles. i.e., you started with 0.55.18 (first release channel build) and enabled rewards, started adding sites to your a-c table, etc. Then you upgraded each time one was available (0.55.20 then 0.55.22, etc). I know I personally encountered this when trying to reproduce #1693.

@GeetaSarvadnya

This comment has been minimized.

Copy link
Collaborator

GeetaSarvadnya commented Dec 13, 2018

@da2x

This comment has been minimized.

Copy link

da2x commented Dec 13, 2018

The specific number we're seeing here, 4294967295 (0xffffffff), is the maximum you can hold in an unsigned integer. Could be caused by setting a value to -1 somewhere where negative values are unsupported.

Does excluding a website change a value somewhere from 1 to 0? If this could be executed twice then it would result in a -1. QA can try double-excluding a site (clicking fast? busy hard drive?) to reproduce the issue.

@michaelw

This comment has been minimized.

Copy link

michaelw commented Dec 27, 2018

Same issue, I did not exclude any website at all:
Version 0.58.18 Chromium: 71.0.3578.98 (Official Build) (64-bit) (MacOS)

screen shot 2018-12-26 at 18 39 49

@funwhilelost

This comment has been minimized.

Copy link

funwhilelost commented Jan 25, 2019

I'm seeing a similar thing in my Windows 10 installation. When I start excluding sites from auto-contribute things start to get weird: percentages add up to many 100's of percent. So I go back to "reset" my auto contribute and then it shows some normal looking values, and a handful and MAXINT at the bottom:

Before reset:
autocontribute

After reset:
reset

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment