Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
excluding sites via x sometimes results in one single site having a huge % value #2086
I tried removing some sites via the x icon in popup which displays the full list of auto contribute sites, and I noticed that sometimes one of my sites gets displayed with a crazy huge percentage.
Steps to Reproduce
See that a site shows up at the bottom with a crazy huge percentage value which changes (probably because the playlist is still running in the background)
No site should have that large of a % value
Reproduces how often:
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
This was also reported on community but with some different steps:
@ryanml the only real direction I have is that it seems to be related to upgraded profiles. i.e., you started with 0.55.18 (first release channel build) and enabled rewards, started adding sites to your a-c table, etc. Then you upgraded each time one was available (0.55.20 then 0.55.22, etc). I know I personally encountered this when trying to reproduce #1693.
The specific number we're seeing here, 4294967295 (0xffffffff), is the maximum you can hold in an unsigned integer. Could be caused by setting a value to -1 somewhere where negative values are unsupported.
Does excluding a website change a value somewhere from 1 to 0? If this could be executed twice then it would result in a -1. QA can try double-excluding a site (clicking fast? busy hard drive?) to reproduce the issue.
referenced this issue
Dec 27, 2018
I'm seeing a similar thing in my Windows 10 installation. When I start excluding sites from auto-contribute things start to get weird: percentages add up to many 100's of percent. So I go back to "reset" my auto contribute and then it shows some normal looking values, and a handful and MAXINT at the bottom: