Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing flag for contribution retries #2102

Closed
NejcZdovc opened this issue Nov 12, 2018 · 0 comments
Closed

Add testing flag for contribution retries #2102

NejcZdovc opened this issue Nov 12, 2018 · 0 comments

Comments

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Nov 12, 2018

Add flag which can enable shorter retries intervals so that QA can test if contribution retries are working.

We should refactor existing rewards flags, so that we can do them with something like:
--rewards=env=prod,reconcile-interval=5. This way we can easily add new ones in the future and we are not bloating utils files.

@NejcZdovc NejcZdovc self-assigned this Nov 12, 2018
@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Nov 12, 2018
NejcZdovc added a commit that referenced this issue Nov 13, 2018
Partial for #2102
@NejcZdovc NejcZdovc mentioned this issue Nov 13, 2018
5 of 16 tasks complete
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 13, 2018
@NejcZdovc NejcZdovc mentioned this issue Nov 13, 2018
6 of 18 tasks complete
@NejcZdovc NejcZdovc added the QA/No label Nov 13, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 13, 2018
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to Pending review in Rewards Nov 13, 2018
@NejcZdovc NejcZdovc added this to the 0.57.x - Beta milestone Nov 13, 2018
NejcZdovc added a commit that referenced this issue Nov 13, 2018
Partial for #2102
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 14, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 19, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 21, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 22, 2018
Rewards automation moved this from Pending review to Completed Nov 26, 2018
@NejcZdovc NejcZdovc removed this from Completed in Rewards Nov 26, 2018
mihaiplesa added a commit that referenced this issue Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.