Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModalBackupRecovery dialogue should used updated component #2146

Closed
ryanml opened this issue Nov 15, 2018 · 1 comment
Closed

ModalBackupRecovery dialogue should used updated component #2146

ryanml opened this issue Nov 15, 2018 · 1 comment
Assignees
@ryanml
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes feature/rewards release-notes/exclude
Milestone
0.58.x - Release ...

Comments

@ryanml
Copy link
Member

@ryanml ryanml commented Nov 15, 2018

The updated component is available as of brave-ui@0.34.1, slight modification will need to be made to pageWallet.tsx to use number type for activeTabId
@ryanml ryanml self-assigned this Nov 15, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Nov 15, 2018
@ryanml
Fixes brave/brave-browser#2146, brave-ui -> v0.34.1
323f6b0
@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Nov 15, 2018
@ryanml ryanml mentioned this issue Nov 15, 2018
Merged
5 of 18 tasks complete
ryanml added a commit to ryanml/brave-core that referenced this issue Nov 19, 2018
@ryanml
Fixes brave/brave-browser#2146, brave-ui -> v0.34.1
141235a
Rewards automation moved this from Untriaged Backlog to Completed Nov 19, 2018
@NejcZdovc NejcZdovc added this to the 0.59.x - Nightly milestone Nov 19, 2018
@NejcZdovc NejcZdovc added the QA/Yes label Nov 19, 2018
@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Dec 11, 2018 •
edited by srirambv

Verified passed with

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7 x64

Used STR from brave/brave-core#909

Verification passed on

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux
@kjozwiak kjozwiak mentioned this issue Dec 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes feature/rewards release-notes/exclude
Projects
None yet
Milestone
  0.58.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

Updates brave-ui -> v0.34.1
6 participants
@kjozwiak @ryanml @NejcZdovc @srirambv @LaurenWags @btlechowski
You can’t perform that action at this time.