Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make url bar suggestion provider work from top 500 #22

Closed
bbondy opened this issue Dec 5, 2017 · 7 comments
Closed

Make url bar suggestion provider work from top 500 #22

bbondy opened this issue Dec 5, 2017 · 7 comments
Assignees
@AlexeyBarabash
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Dec 5, 2017 •
edited by AlexeyBarabash

  • Make URL bar suggestions work from top 500
  • Disable search suggestions by default always
@bbondy bbondy added this to the Milestone 1: To be able to open source the repo milestone Dec 5, 2017
@AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Dec 26, 2017

This is done in branches https://github.com/brave/brave/tree/topsites_suggestions, https://github.com/brave/antimuon/tree/topsites_suggestions. Antimuon is derived from shields branch and uses uses Chrome 62.
@AlexeyBarabash AlexeyBarabash mentioned this issue Dec 26, 2017
Closed
@AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Dec 26, 2017

Updated branches from master https://github.com/brave/brave/tree/topsites_suggestions_cr63 , https://github.com/brave/antimuon/tree/topsites_suggestions_cr63 .
Made PR brave/brave-core#8 .
@AlexeyBarabash AlexeyBarabash mentioned this issue Jan 4, 2018
Merged
@AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Jan 4, 2018 •
edited

Re-merged PR brave/brave-core#18 after new patch system.
@bbondy
Copy link
Member Author

@bbondy bbondy commented Mar 19, 2018

This was merged already, so closing.
@bbondy bbondy closed this Mar 19, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #22 from brave/customize_tab_shape
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
64f3a3c 
rectangle tab shape
@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Releasable builds Jun 13, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@btlechowski
Copy link
Collaborator

@btlechowski btlechowski commented Sep 21, 2018 •
edited by kjozwiak

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
@kjozwiak kjozwiak added QA Pass-macOS and removed QA/Yes labels Sep 25, 2018
@bbondy bbondy added the QA/Yes label Sep 27, 2018
@hamzahkhan
Copy link

@hamzahkhan hamzahkhan commented Jan 7, 2019

Do we have this feature of URL bar recommendations in the new update or yet to be published?
@elibroftw
Copy link

@elibroftw elibroftw commented Apr 26, 2019

brave://settings/?search=use+a+prediction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
@bbondy @kjozwiak @srirambv @elibroftw @AlexeyBarabash @hamzahkhan @btlechowski
You can’t perform that action at this time.