Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync should throw error if system time is not accurate with difference more than 2 minutes #2262

Closed
cezaraugusto opened this issue Nov 28, 2018 · 2 comments
Closed

Sync should throw error if system time is not accurate with difference more than 2 minutes #2262

cezaraugusto opened this issue Nov 28, 2018 · 2 comments
Assignees
@darkdh
Labels
feature/sync
Milestone
0.58.x - Release ...

Comments

@cezaraugusto
Copy link
Member

@cezaraugusto cezaraugusto commented Nov 28, 2018

This was originally a bullet from #2103. Carried over from there as the PR for that issue does not address this.

If system time is not accurate, sync should throw an error warning the user.

cc @AlexeyBarabash
@cezaraugusto cezaraugusto mentioned this issue Nov 28, 2018
Closed
@bbondy bbondy added this to the 1.x Backlog milestone Dec 2, 2018
@bbondy bbondy added this to P1 & P2 backlog in Sync Dec 3, 2018
@darkdh darkdh self-assigned this Dec 5, 2018
@darkdh
Copy link
Member

@darkdh darkdh commented Dec 10, 2018

This is handled by ERR_SYNC_INIT_FAILED
but we can specify more granular error info in https://github.com/brave/sync in the future.
@darkdh darkdh closed this Dec 10, 2018
Sync automation moved this from P1 & P2 backlog to Completed Dec 10, 2018
@darkdh
Copy link
Member

@darkdh darkdh commented Dec 10, 2018

ERR_SYNC_INIT_FAILED will be triggered by

  1. unable to connect to sync server
  2. local machine time is out of date
@darkdh darkdh mentioned this issue Dec 14, 2018
Closed
@bbondy bbondy modified the milestones: 1.x Backlog, 0.58.x - Release Dec 20, 2018
@kjozwiak kjozwiak mentioned this issue Jan 31, 2019
Closed
@rebron rebron removed this from Completed in Sync Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/sync
Projects
None yet
Milestone
  0.58.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@bbondy @cezaraugusto @darkdh
You can’t perform that action at this time.