Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bat-native-ledger DEPS for master / 0.59.x #2298

Closed
bsclifton opened this issue Nov 29, 2018 · 1 comment
Closed

Fix bat-native-ledger DEPS for master / 0.59.x #2298

bsclifton opened this issue Nov 29, 2018 · 1 comment
Assignees
@bsclifton
Labels
QA/No dependency/update release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Nov 29, 2018 •
edited

Unfortunately brave/brave-core#910 specified the wrong SHA for the DEPs.

This was merged to master and 0.59.x (but not further). We'll need to update these to use the 0.58.x branch of https://github.com/brave-intl/bat-native-ledger/
@bsclifton bsclifton self-assigned this Nov 29, 2018
bsclifton added a commit to brave/brave-core that referenced this issue Nov 29, 2018
@bsclifton
Update bat-native-ledger DEPS reference to be 0.58.x
Unverified
This user has not uploaded their public key yet.
GPG key ID: 37FF5F19022427F2 Learn about signing commits
Loading status checks…
005b47e 
Fixes brave/brave-browser#2298
@bsclifton bsclifton mentioned this issue Nov 29, 2018
Merged
6 of 18 tasks complete
@bsclifton
Copy link
Member Author

@bsclifton bsclifton commented Nov 29, 2018 •
edited

Before brave/brave-core#910, DEPS was pointing at brave-intl/bat-native-ledger@a12e503 in brave-core on master and 0.59.x

The 0.58.x branch includes this SHA (along with the one needed for brave/brave-core#910)

brave-core 0.57.x and 0.58.x have correct DEPS references because I caught this after merging brave/brave-core#910 to 0.59.x. I then submitted:

Which was merged and set the proper refs when finishing cherry-picking for brave/brave-core#910
@bsclifton bsclifton added this to the 0.59.x - Dev milestone Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
QA/No dependency/update release-notes/exclude
Projects
None yet
Milestone
  0.59.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

Update bat-native-ledger DEPS reference to be 0.58.x
2 participants
@bbondy @bsclifton
You can’t perform that action at this time.