Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

silent installer still displaying UI elements #2356

Closed
kjozwiak opened this issue Dec 4, 2018 · 1 comment
Closed

silent installer still displaying UI elements #2356

kjozwiak opened this issue Dec 4, 2018 · 1 comment
Assignees
@mbacchi @simonhong
Labels
OS/Windows QA Pass-Win64 QA/Yes bug installer/omaha release-notes/exclude setup/installer
Milestone
0.57.x - Release ...

Comments

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Dec 4, 2018 •
edited

Description

When attempting to install Brave using the new silent installers, the Downloading, Installing and Done UI elements are still being displayed during the process.

Steps to Reproduce

  1. download the silent installer using https://laptop-updates-pre.brave.com/download/WBD896
  2. once downloaded, execute either BraveBrowserSilentSetup32-WBD896.exe or BraveBrowserSilentSetup-WBD896.exe

Actual result:

screen shot 2018-12-04 at 11 51 43 am

screen shot 2018-12-04 at 11 51 49 am

screen shot 2018-12-04 at 11 53 33 am

Expected result:

There should be no UI being displayed when using a silent installer

Reproduces how often:

100% reproducible using the above STR.

Additional Information

  • Win 10 x64 VM - FAILED (UI elements were being displayed)
  • Win 10 x86 VM - FAILED (UI elements were being displayed)
  • Win 8.1 x64 VM - FAILED (UI elements were being displayed)
  • Win 8.1 x86 VM - FAILED (UI elements were being displayed)

CCing @davidtemkin @aekeus @mandar-brave
@kjozwiak kjozwiak added this to the 0.57.x - Release milestone Dec 4, 2018
@simonhong simonhong self-assigned this Dec 5, 2018
@simonhong simonhong mentioned this issue Dec 5, 2018
Merged
@simonhong simonhong mentioned this issue Dec 5, 2018
Merged
6 of 18 tasks complete
@kjozwiak kjozwiak added the OS/Windows label Dec 6, 2018
@kjozwiak
Copy link
Member Author

@kjozwiak kjozwiak commented Dec 6, 2018

Windows 10 x64:

  • installed 0.57.17 Chromium: 71.0.3578.80 using BraveBrowserStandaloneSilentSetup.exe and ensured no UI was displayed - PASSED
  • installed 0.56.15 Chromium: 70.0.3538.110 using BraveBrowserSilentSetup.exe and ensured no UI was displayed - PASSED

Windows 10 x86:

  • installed 0.57.17 Chromium: 71.0.3578.80 using BraveBrowserStandaloneSilentSetup32.exe and ensured no UI was displayed - PASSED
  • installed 0.56.15 Chromium: 70.0.3538.110 using BraveBrowserSilentSetup32.exe and ensured no UI was displayed - PASSED

Windows 8.1 x64:

  • installed 0.57.17 Chromium: 71.0.3578.80 using BraveBrowserStandaloneSilentSetup.exe and ensured no UI was displayed - PASSED
  • installed 0.56.15 Chromium: 70.0.3538.110 using BraveBrowserSilentSetup.exe and ensured no UI was displayed - PASSED

Windows 8.1 x86:

  • installed 0.57.17 Chromium: 71.0.3578.80 using BraveBrowserStandaloneSilentSetup32.exe and ensured no UI was displayed - PASSED
  • installed 0.56.15 Chromium: 70.0.3538.110 using BraveBrowserSilentSetup32.exe and ensured no UI was displayed - PASSED

Windows 7 x64:

  • installed 0.57.17 Chromium: 71.0.3578.80 using BraveBrowserStandaloneSilentSetup.exe and ensured no UI was displayed - PASSED
  • installed 0.56.15 Chromium: 70.0.3538.110 using BraveBrowserSilentSetup.exe and ensured no UI was displayed - PASSED

Windows 7 x86:

  • installed 0.57.17 Chromium: 71.0.3578.80 using BraveBrowserStandaloneSilentSetup32.exe and ensured no UI was displayed - PASSED
  • installed 0.56.15 Chromium: 70.0.3538.110 using BraveBrowserSilentSetup32.exe and ensured no UI was displayed - PASSED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbacchi mbacchi

@simonhong simonhong

Labels
OS/Windows QA Pass-Win64 QA/Yes bug installer/omaha release-notes/exclude setup/installer
Projects
None yet
Milestone
  0.57.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

Update omaha repo to support silent tag
3 participants
@kjozwiak @mbacchi @simonhong
You can’t perform that action at this time.