Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Join" extension won't function in Brave #2408

Closed
Brave-Matt opened this issue Dec 7, 2018 · 9 comments
Closed

"Join" extension won't function in Brave #2408

Brave-Matt opened this issue Dec 7, 2018 · 9 comments
Labels
bug feature/extensions needs-more-info The report requires more detail before we can decide what to do with this issue. priority/P5 Not scheduled. Don't anticipate work on this any time soon. webcompat/shields Shields is breaking a website.

Comments

@Brave-Matt
Copy link
Collaborator

Description

Several users have brought to my attention that apps like "Join" won't work in Brave with #1380.
Devices cannot communicate and device the extension is installed on remains "unrecognized". Diagnostics in the extension show the following errors:
image

Steps to Reproduce

  1. Install Join extension
  2. Try to use the extension
  3. When it doesn't work, run diagnostics

Actual result:

Extension doesn't function

Expected result:

Extension should work and device should be recognized.

Reproduces how often:

Easily/always

Brave version (brave://version info)

All current builds
Release Build v0.57.18
Beta build v0.57.8
Developer build v0.59.2

Reproducible on current release:

Yes

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No

Additional Information

No Shields settings, in domain-specific or global, have any effect.

@Brave-Matt Brave-Matt added the webcompat/shields Shields is breaking a website. label Dec 7, 2018
@kjozwiak kjozwiak added this to the 1.x Backlog milestone Dec 18, 2018
@rebron rebron added this to Untriaged Backlog in General Jan 8, 2019
@rebron rebron added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Jan 8, 2019
@rebron rebron moved this from Untriaged Backlog to Needs Info in General Jan 15, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@darthShadow
Copy link

This is still an issue with the latest version of the browser (0.60.47 Chromium: 72.0.3626.119 (Official Build) (64-bit)). Anything I can do to help get this resolved faster? Basically, the only thing preventing me from switching fully to Brave.

@anthonyrebel
Copy link

This is still an issue with the latest version of the browser (0.60.47 Chromium: 72.0.3626.119 (Official Build) (64-bit)). Anything I can do to help get this resolved faster? Basically, the only thing preventing me from switching fully to Brave.

FWIW - When I started collecting errors on the extension it failed on line 1963 with the following error: Error: File doesn't exist on your google drive: storedpushes=:=undefined.

In addition, when you run through the GCM Internals the connection state comes up as false.

I haven't spent a lot of time on this issue, but in my case it acts like it's not integrated with Google Drive even though I went through the setup. I've only been able to reproduce this issue in Brave. Going through setup in Chrome and Canary still works.

@bbondy bbondy added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 5, 2019
@rebron rebron moved this from Needs Info to P5 Backlog in General Mar 14, 2019
@Brave-Matt
Copy link
Collaborator Author

@jdnixx
Copy link

jdnixx commented Apr 28, 2019

Hey, if it helps:
If you go to Join's chrome extension store page, in the "Support" tab, the user Sean Blonien posted 2 days ago (so Apr. 27 2019):
image
So it looks like the problem is related to regId?

@FappyMcFap
Copy link

+1 I rely on this extension quite a bit.

@ReeSilva
Copy link

+1

@LesterCovax
Copy link

It's working perfectly now in Brave Dev Version 0.72.110 Chromium: 78.0.3904.70 after enabling Use Google Services for Push Messaging (Added in v0.72.73 - #2301 / brave/brave-core#3390 / brave/brave-core@cd3df93) . This finally enables Brave to work with Firebase Cloud Messaging, after GCM having been deprecated earlier this year (more info: GCM/FCM FAQ).
Note: This feature isn't available yet in Release/Beta channels.

There appears to be a bug though, where clicking the Relaunch button after toggling it on, untoggles the setting before relaunching. I got around this by toggling it on, and then running chrome://restart in a new tab. I've created #6633 for the bug.

  • Step 1: Use Google Services for Push Messaging :feelsgood:
  • Step 2: ‽‽‽‽‽
  • Step 3: Profit!!! 🤑💸

@mickdekkers
Copy link

Can confirm, Join works great in Brave now. You just need to enable Google Services for Push Messaging as @LesterCovax showed. I'm on the Release channel, so it looks like this feature has made its way there.

Join has a self-test function under the diagnostics tab. All the tests pass in Brave 🎉

A screenshot of Join's diagnostics tab, taken after running the tests in Brave. All the tests have passed.

Tested on Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) (64-bit).

@bsclifton
Copy link
Member

Thanks for confirming, folks! 😄

General automation moved this from P5 Backlog to Completed Dec 31, 2019
@rebron rebron removed this from Completed in General Jan 7, 2020
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/extensions needs-more-info The report requires more detail before we can decide what to do with this issue. priority/P5 Not scheduled. Don't anticipate work on this any time soon. webcompat/shields Shields is breaking a website.
Projects
None yet
Development

No branches or pull requests