Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards panel has extra padding after rewards summary #2486

Closed
srirambv opened this issue Dec 12, 2018 · 4 comments
Closed

Rewards panel has extra padding after rewards summary #2486

srirambv opened this issue Dec 12, 2018 · 4 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Dec 12, 2018

Description

Rewards panel has extra padding after rewards summary

Steps to Reproduce

  1. Enable rewards on 0.58.11
  2. Visit any site and click on the rewards panel
  3. See screenshot

Actual result:

screenshot from 2018-12-12 16-05-46

Expected result:

Should not contain any unnecessary padding

Reproduces how often:

Easy

Brave version (brave://version info)

All platforms on 0.58.11

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@srirambv srirambv added this to the 1.x Backlog milestone Dec 12, 2018
@srirambv srirambv added this to Untriaged Backlog in Rewards via automation Dec 12, 2018
@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Dec 12, 2018

@ryanml Logged this issue because brave/brave-core#957 was reverted. Also i think the PR originally was intended to have brave/brave-core#957 (review). Could we have a separate PR done for this issue and not club with other UI fixes.

cc: @brave/legacy_qa @NejcZdovc @jasonrsadler @bbondy

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Dec 12, 2018

If brave/brave-core#957 doesn't end up landing in 0.58.x, we definitely need to make sure that the "empty" space is fixed before we ship 0.58.x. Just looks very strange.

@kjozwiak kjozwiak modified the milestones: 1.x Backlog, 0.58.x - Beta Dec 12, 2018
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Dec 12, 2018

After talking to @NejcZdovc, we won't be including the custom amounts in 0.58.x but will have a simple PR that fixes the above UI issue. 👍

@ryanml ryanml mentioned this issue Dec 12, 2018
4 of 18 tasks complete
Rewards automation moved this from Untriaged Backlog to Completed Dec 13, 2018
Rewards Team automation moved this from Ryan to Closed Dec 13, 2018
@NejcZdovc NejcZdovc moved this from Completed to Waiting uplift in Rewards Dec 13, 2018
@NejcZdovc NejcZdovc moved this from Waiting uplift to Completed in Rewards Dec 13, 2018
@btlechowski
Copy link
Collaborator

@btlechowski btlechowski commented Dec 17, 2018

Verification passed on

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

The padding after rewards summary is smaller, but still not fully fixed. Logged #2590

Verification PASSED on macOS 10.14 x64 using the following build:

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X
  • commented on #2590 as it's also reproducible on macOS

Verification passed on Ubuntu 17..10

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.