Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wording on bookmark manager and favicon to remove reference to star icon #2494

Closed
LaurenWags opened this issue Dec 12, 2018 · 7 comments
Closed

Comments

@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Dec 12, 2018

Description

When you navigate to the bookmarks manager and you don't have any bookmarks yet (or you navigate to a folder within bookmark manager that does not have any bookmarks) you're shown instructional text that says 'To bookmark pages, click the star in the address bar' - however, there's no star for you to click as we changed icons. This wording should be updated to reflect changed icon.

Steps to Reproduce

  1. Navigate to bookmarks manager.
  2. If you don't have any bookmarks, you'll see the text in the image below.
  3. If you have bookmarks, create a new folder and open it in the bookmark manager.

Actual result:

screen shot 2018-12-12 at 12 48 53 pm

Expected result:

Text should be updated to reflect changed icon.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Dec 12, 2018
@rebron rebron self-assigned this Dec 13, 2018
@rebron rebron added this to Untriaged Backlog in Front End Dec 14, 2018
@rebron rebron added this to Untriaged Backlog in General Dec 18, 2018
@rebron rebron added the priority/P4 label Dec 18, 2018
@rebron rebron moved this from Untriaged Backlog to P3, P4, & P5 Backlog in General Dec 18, 2018
@rebron rebron moved this from Untriaged Backlog to Prioritized Backlog in Front End Jan 15, 2019
@rebron rebron removed this from P3 & P4 Backlog in General Jan 15, 2019
@rebron rebron removed this from Prioritized Backlog in Front End Jan 15, 2019
@rebron rebron added this to P3, P4 & P5 backlog in Settings Jan 15, 2019
@rebron rebron removed their assignment Jan 16, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron

This comment has been minimized.

Copy link
Collaborator

@rebron rebron commented Feb 13, 2019

Text should be:

To bookmark pages, click the bookmarks button next to the address bar.

@rebron

This comment has been minimized.

Copy link
Collaborator

@rebron rebron commented Feb 13, 2019

cc: @petemill can you take at look if you're in brave://bookmarks already.

@rebron rebron closed this Mar 13, 2019
@rebron rebron moved this from P3, P4 backlog to Completed in Settings Mar 13, 2019
@rebron rebron reopened this Mar 13, 2019
@rebron rebron moved this from Completed to P1 & P2 Backlog in Settings Mar 13, 2019
@rebron rebron moved this from P1 & P2 Backlog to P3, P4 backlog in Settings Mar 13, 2019
@eltonbaroncello

This comment has been minimized.

Copy link

@eltonbaroncello eltonbaroncello commented Apr 10, 2019

@LaurenWags this bookmark button on the left side of the location bar, it's turning the transition experience a bit annoying. There's any chance to change it. 😒

@LaurenWags

This comment has been minimized.

Copy link
Collaborator Author

@LaurenWags LaurenWags commented Apr 10, 2019

@eltonbaroncello I'm not aware of any plans to move the location of the bookmark button.

@rebron

This comment has been minimized.

Copy link
Collaborator

@rebron rebron commented May 20, 2019

Let's also address the favicon in the Bookmarks tab at the top by using our bookmarks icon.

@rossmoody rossmoody changed the title update wording on bookmark manager to remove reference to star icon update wording on bookmark manager and favicon to remove reference to star icon May 22, 2019
@rossmoody

This comment has been minimized.

Copy link
Contributor

@rossmoody rossmoody commented May 22, 2019

DM'd Raf: copy finalized to : To add a bookmark, click the bookmark button next to the address bar

@rossmoody rossmoody removed their assignment Aug 13, 2019
@simonhong simonhong self-assigned this Jan 9, 2020
simonhong added a commit to brave/brave-core that referenced this issue Jan 10, 2020
@simonhong simonhong added this to the 1.5.x - Nightly milestone Jan 10, 2020
@simonhong simonhong mentioned this issue Jan 10, 2020
7 of 32 tasks complete
simonhong added a commit to brave/brave-core that referenced this issue Jan 15, 2020
simonhong added a commit to brave/brave-core that referenced this issue Jan 15, 2020
simonhong added a commit to brave/brave-core that referenced this issue Jan 15, 2020
simonhong added a commit to brave/brave-core that referenced this issue Jan 15, 2020
@rebron rebron moved this from P4 backlog to In progress in Settings Jan 21, 2020
@rebron rebron moved this from In progress to Completed in Settings Jan 21, 2020
@GeetaSarvadnya

This comment has been minimized.

Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Mar 2, 2020

Verification passed on

Brave 1.5.102 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description
  • Verified on both clean and upgraded profile
    image

Verified passed with

Brave 1.5.105 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Reproduced original issue with 1.4.95:
Screen Shot 2020-03-02 at 3 30 59 PM

Updated to 1.5.105 and confirmed text matches #2494 (comment):
Screen Shot 2020-03-02 at 3 32 12 PM

  • Also confirmed on a clean profile

Screen Shot 2020-03-02 at 3 35 41 PM

Verification passed on

Brave 1.5.106 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description
  • Verified on both clean and upgraded profile

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

8 participants
You can’t perform that action at this time.