Geolocations permission prompt

[bbondy]

No description provided.

[bbondy]

@jumde could you help define what we are missing here in comparison to browser-laptop?

[srirambv]

• Media Autoplay (Allow/Deny/Ask)

[bbondy]

I did see one of these prompts, I suspect maybe some domains are whitelisted for no prompt?

[bbondy]

I think google.com asked me but I think maps.google.com didn't.

[jumde]

On navigating to google.com I do see a geolocation prompt on using browser-laptop but, the prompt is not displayed with brave-core.

[srirambv]

Location prompt shows up but doesn't show user location (#783)

I think this issue can be closed as its working on master and on packaged build.

[bbondy]

This should already be implemented, there was a CI issue which should be resolved on the next build. I'll mark the QA flags to ensure that. cc @mbacchi

[GeetaSarvadnya]

Notification prompt is still not displayed for google.com. May be fix is not available in this build.

Brave	0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision	9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS	Windows

[mbacchi]

We are building all platforms with the geolocation key and endpoint now, and I've just verified that 0.54.2 enables it on Linux:

I had to remove the preferences directory (in Linux it was: ~/.config/BraveSoftware/Brave-Browser-Dev/) to make this prompt me as I had already allowed browserleaks to see my location in the past. Maybe you need to remove that directory and try again?

[srirambv]

still doesn't prompt for google.com. Only works on browserleaks.com/geo

[bbondy]

file a new issue pls @srirambv

[srirambv]

Verification Passed on

Brave	0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Linux

• Verified permission prompted on https://maps.google.com/ when clicked on location
• Verified permission prompted for https://browserleaks.com/geo

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}

• Verified permission prompts on https://maps.google.com/
• Verified permission prompts on https://browserleaks.com/geo
• Verified permission prompts on https://html5demos.com/geo/
• Verified permission prompts on https://permission.site/