Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn more about Brave Wallet should look like a hyperlink rather than a greyed out text #25201

Closed
srirambv opened this issue Sep 4, 2022 · 3 comments · Fixed by brave/brave-core#21916
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Sep 4, 2022

Description

Learn more about Brave Wallet should look like a hyperlink rather than a greyed out text

Steps to Reproduce

  1. Clean profile
  2. Open brave://wallet
  3. Learn more message looks like a greyed out text and doesn't look like a hyperlink

Actual result:

Dark Light
image image

Expected result:

Should differentiate between normal text vs hyperlink

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.45.22 Chromium: 105.0.5195.68 (Official Build) nightly (64-bit)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @jamesmudgett @josheleonard

@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes onboarding Front-end related to helping a new user learn about features within the browser. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Sep 4, 2022
@wolbek
Copy link

wolbek commented Oct 8, 2022

I would like to contribute to this issue.

@wolbek
Copy link

wolbek commented Oct 9, 2022

@srirambv I have made a pull request regarding the issue, will you please review it? If any more changes are needed, mention them and I will work on them ASAP.

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.64.97 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
Revision f7c8f13563bfe1063db456650cb43207e1c960c0
OS Windows 11 Version 23H2 (Build 22631.3155)
  • Verified steps from brave/brave-core#21916
  • Verified Learn more about Brave Wallet now has a better hyperlink feel than before
  • Verified on both light and dark theme link is properly visible
25201.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
4 participants