Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sidebar setting to show on the right or left side of the browser #25332

Closed
fallaciousreasoning opened this issue Sep 12, 2022 · 3 comments · Fixed by brave/brave-core#15315
Closed

Add sidebar setting to show on the right or left side of the browser #25332

fallaciousreasoning opened this issue Sep 12, 2022 · 3 comments · Fixed by brave/brave-core#15315
Assignees
@simonhong
Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@fallaciousreasoning
Copy link
Collaborator

Description

In brave://settings/appearance there is a setting for which side the side panel should be shown on:
image

Steps to Reproduce

  1. Open the side panel
  2. In brave://settings/appearance set the side panel to Show on right

Actual result:

The side panel remains on the left.
image

Expected result:

The side panel should swap sides based on the setting.

Reproduces how often:

Every time.

Brave version (brave://version info)

1.45.30 Chromium: 105.0.5195.102 (Developer Build) (64-bit)
1.44.75 Chromium: 105.0.5195.102 (Official Build) beta (64-bit)
@fallaciousreasoning fallaciousreasoning added OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Sep 12, 2022
@fallaciousreasoning
Copy link
Collaborator Author

cc @rebron for thoughts on priority.

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes labels Sep 12, 2022
@rebron rebron added this to On Deck in Settings Sep 13, 2022
@simonhong simonhong self-assigned this Sep 28, 2022
@simonhong
Copy link
Member

Revert brave/brave-core#15270 when we fix this isue.

@simonhong simonhong mentioned this issue Oct 4, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Oct 4, 2022
@simonhong
Enable sidebar on right side option
370801d 
fix brave/brave-browser#25332
fix brave/brave-browser#25756

Also custom bubble border is removed and used upstream's bubble border.
With upstream's bubble border, we don't need to care about arrow flipping
whenever changing sidebar's option.
@simonhong simonhong added this to the 1.46.x - Nightly milestone Oct 4, 2022
@rebron rebron moved this from On Deck to Completed in Settings Oct 4, 2022
@stephendonner
Copy link
Collaborator

Verified PASSED using

Brave 1.46.76 Chromium: 107.0.5304.62 (Official Build) beta (x86_64)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS macOS Version 11.7 (Build 20G817)

Steps:

  1. installed 1.46.76
  2. launched Brave
  3. opened brave://settings/appearance
  4. noted the default position and value of Side panel is Show on left
  5. clicked on the Show on right radio button and noted its position changed
  6. also tested in Dark mode

Light:

Show on left Show on right
Screen Shot 2022-10-24 at 3 19 28 PM Screen Shot 2022-10-24 at 3 19 34 PM

Dark:

Show on left Show on right
Screen Shot 2022-10-24 at 3 19 53 PM Screen Shot 2022-10-24 at 3 19 49 PM

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
@rebron rebron changed the title Settings for which side the sidebar shows on have no effect Add sidebar setting to show on the right or left side of the browser Nov 30, 2022
@rebron rebron removed this from Completed in Settings Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Enable sidebar on right side brave/brave-core
4 participants
@stephendonner @rebron @simonhong @fallaciousreasoning