Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely hard to tell if tab is private or Tor in new version #2735

Open
Qix- opened this issue Dec 25, 2018 · 5 comments
Open

Extremely hard to tell if tab is private or Tor in new version #2735

Qix- opened this issue Dec 25, 2018 · 5 comments

Comments

@Qix-
Copy link

@Qix- Qix- commented Dec 25, 2018

Brave version: Version 0.58.18 Chromium: 71.0.3578.98 (Official Build) (64-bit)

In the new flashy Brave UI, it's almost impossible to tell if the tab is private or private with Tor. This is a severe downgrade from the old UI where it was at least easily recognizable at a glance.

This, along with #2734, make for a pretty sizable setback in Tor experience in Brave :/

@srirambv srirambv added this to the 1.x Backlog milestone Dec 25, 2018
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Dec 25, 2018

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Dec 28, 2018

TBH on Linux with GTX dark theme by default its only possible to distuingush if you have a new tab open which makes it clear what kind of window you are on
image

On Windows, you'd have different taskbar icons for each Private/Tor/Normal windows so its easy to guess which window is which but on Linux all the windows gets clubbed under one icon and keyboar shortcut isn't that user friendly to switch tabs of the same browser profile

screenshot from 2018-12-28 10-54-10

Unless we can override the chrome colour profile on the Guest Window I don't think it will be much helpful in terms of UI distinction of Private/Tor windows

cc: @petemill @simonhong

@Qix-
Copy link
Author

@Qix- Qix- commented Dec 28, 2018

Well in the old version you could see "tor" in the tab. That was helpful enough. You'd also see "connecting to tor" in the address bar.

However, I don't see any of that anymore which leads me to believe that I'm not actually connected, which gives me lots of anxiety (: especially since things feel faster to connect in the new brave, which generally isn't a good sign when dealing with Tor.

So now I'm left with doubt about whether or not Brave is working as intended. The cognitive stress is much, much higher.

@rebron rebron added this to Untriaged Backlog in Front End Jan 8, 2019
@tomlowenthal
Copy link
Member

@tomlowenthal tomlowenthal commented Jan 11, 2019

In private windows with Tor, the word "Tor" is visible on the right, next to the menu button. On regular private windows, you see a pair of sunglasses there instead. But that's certainly not an easy way to tell windows apart at a glance, from menu bars, or so on.

@tomlowenthal tomlowenthal added this to Untriaged in Tor and Private Windows via automation Jan 11, 2019
@rebron rebron moved this from Untriaged Backlog to Blue Sky in Front End Jan 15, 2019
@tomlowenthal tomlowenthal moved this from Untriaged to Backlog in Tor and Private Windows Jan 24, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@rossmoody rossmoody self-assigned this May 31, 2019
@rossmoody rossmoody removed their assignment Jul 4, 2019
@NumDeP
Copy link

@NumDeP NumDeP commented Sep 12, 2019

Please keep in mind Session-Tabs when working on this feature because I remember this was also a concern for many users for when dozens of tabs started to shrink different tab types in the Muon version of Brave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Front End
  
P4 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.