New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave (RC v0.58.18) Shields settings not respected by several domains #2770
Comments
+1 |
@Brave-Matt can you verify this isn't an issue in 59.x/60.x? |
Turns out this was due to a corrupt profile. It's unclear what caused it, but after creating a new profile I was able to resume normal site function in Release. @bsclifton is examining data pulled from the corrupted profile to find possible causes. |
@Brave-Matt I was unable to load the profile you shared. You can DM me with another copy if you're still seeing this issue. We did land a major CORS fix in 0.58.21... that should have helped in general. But that wouldn't explain problems with shields Need more info to investigate |
Closing as stale. |
Description
I’m seeing a lot of Shields config. issues in RC v0.58.18. Not sure if this is the exact issue or if it’s related to this one: #2190
☝️ That’s the only issue I can find that describes what I’m seeing. Essentially Shields settings don’t seem to be taking effect for a good number of sites. Several sites (examples below) that have something blocked by Shields (and thus lack some functionality) cannot be fixed by altering site-level Shields for the domain ( Shields = Off), adjusting individual Shields panel settings, or Global Shields settings.
In addition to the obvious problem that users are unable to access/use some sites because of this, it's also causing a lot of confusion with newer users who aren't versed in Shields concepts.
All of the tests were performed on Mac and I was able to repro them in Win10 as well. I've provided several examples/sites that show this behavior but there's likely more effected by it.
Steps to Reproduce
Actual result:
Changes in Shields configuration are not respected, site will continue to display with broken elements or functionality.
Expected result:
Disabling Shields or finding ideal tuning for the site should restore site functionality as intended.
Reproduces how often:
Always
Brave version (brave://version info)
Win10 and macOS
Release Channel build, version 0.58.18
Reproducible on current release:
No
Website problems only:
Additional Information
Examples of sites with this behavior:
The text was updated successfully, but these errors were encountered: