Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave (RC v0.58.18) Shields settings not respected by several domains #2770

Closed
Brave-Matt opened this issue Jan 1, 2019 · 6 comments
Closed
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. regression
Projects

Comments

@Brave-Matt
Copy link
Collaborator

Description

I’m seeing a lot of Shields config. issues in RC v0.58.18. Not sure if this is the exact issue or if it’s related to this one: #2190

☝️ That’s the only issue I can find that describes what I’m seeing. Essentially Shields settings don’t seem to be taking effect for a good number of sites. Several sites (examples below) that have something blocked by Shields (and thus lack some functionality) cannot be fixed by altering site-level Shields for the domain ( Shields = Off), adjusting individual Shields panel settings, or Global Shields settings.

In addition to the obvious problem that users are unable to access/use some sites because of this, it's also causing a lot of confusion with newer users who aren't versed in Shields concepts.

All of the tests were performed on Mac and I was able to repro them in Win10 as well. I've provided several examples/sites that show this behavior but there's likely more effected by it.

Steps to Reproduce

  1. Visit one of the sites listed in my examples (again, could be any site but for the sake of reproducibility its probably easiest to use one of the domains I've confirmed).
  2. Attempt to adjust Shields panel/Global Shields settings and/or disabling Shields to fix [some website function]
  3. Perform the same test in Dev/Beta builds (and/or in chrome)

Actual result:

Changes in Shields configuration are not respected, site will continue to display with broken elements or functionality.

Expected result:

Disabling Shields or finding ideal tuning for the site should restore site functionality as intended.

Reproduces how often:

Always

Brave version (brave://version info)

Win10 and macOS
Release Channel build, version 0.58.18

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    No

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

Examples of sites with this behavior:
hulu2
ignvid
image 1
nbc
netflixfail
apv

@avndp
Copy link

avndp commented Jan 1, 2019

+1

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 2, 2019
@Brave-Matt
Copy link
Collaborator Author

imgur

@rebron rebron added this to Untriaged / Incoming in Shields via automation Jan 3, 2019
@rebron
Copy link
Collaborator

rebron commented Jan 7, 2019

@Brave-Matt can you verify this isn't an issue in 59.x/60.x?

@Brave-Matt
Copy link
Collaborator Author

Turns out this was due to a corrupt profile. It's unclear what caused it, but after creating a new profile I was able to resume normal site function in Release.

@bsclifton is examining data pulled from the corrupted profile to find possible causes.

@bsclifton
Copy link
Member

@Brave-Matt I was unable to load the profile you shared. You can DM me with another copy if you're still seeing this issue. We did land a major CORS fix in 0.58.21... that should have helped in general. But that wouldn't explain problems with shields

Need more info to investigate

@bsclifton bsclifton added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Jan 15, 2019
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 24, 2019
@tildelowengrimm tildelowengrimm moved this from Untriaged / Incoming to Design in Shields Jan 24, 2019
@tildelowengrimm tildelowengrimm moved this from Design to Priority tasks in Shields Jan 24, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@tildelowengrimm tildelowengrimm moved this from Priority tasks to Untriaged / Incoming in Shields Mar 18, 2019
@tildelowengrimm tildelowengrimm moved this from Untriaged / Incoming to Shields Bugs in Shields Mar 18, 2019
@rebron
Copy link
Collaborator

rebron commented May 27, 2022

Closing as stale.

@rebron rebron closed this as completed May 27, 2022
Shields automation moved this from Shields Bugs to Completed May 27, 2022
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed priority/P3 The next thing for us to work on. It'll ride the trains. needs-more-info The report requires more detail before we can decide what to do with this issue. labels May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. regression
Projects
Shields
  
Completed
Development

No branches or pull requests

6 participants