Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger should not have brave-specific header values #2873

Closed
bridiver opened this issue Jan 9, 2019 · 0 comments
Closed

ledger should not have brave-specific header values #2873

bridiver opened this issue Jan 9, 2019 · 0 comments
Labels
QA/No dev-concern feature/rewards priority/P5 release-notes/exclude
Projects
Rewards Team
Milestone
0.68.x - Release

Comments

@bridiver
Copy link
Collaborator

@bridiver bridiver commented Jan 9, 2019

Description

brave/brave-core@de8c30a#diff-57bef3ab48f1e31e5447a5ffb39808c0R1067 sends brave-product:brave-core from with ledger, but embedders presumably would send a different value
bridiver referenced this issue in brave/brave-core Jan 9, 2019
@NejcZdovc
Use correct captcha
Verified
This commit was signed with a verified signature.
NejcZdovc Nejc Zdovc
GPG key ID: F55DDADFE8E43B0F Learn about signing commits
de8c30a
@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Jan 10, 2019
@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 10, 2019
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Rewards Jan 10, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@NejcZdovc NejcZdovc added this to Jason in Rewards Team Mar 12, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Mar 12, 2019
Jason Sadler
Resolves brave/brave-browser#3676
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
0219ef5 
Resolves brave/brave-browser#2873

Remove Brave specific header
@jasonrsadler jasonrsadler mentioned this issue Mar 12, 2019
Merged
9 of 19 tasks complete
@jasonrsadler jasonrsadler moved this from P3, P4, & P5 Backlog to Pending review in Rewards Mar 13, 2019
@jasonrsadler jasonrsadler added the QA/No label Mar 13, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Mar 13, 2019
Jason Sadler
Resolves brave/brave-browser#3676
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
4cbc1f6 
Resolves brave/brave-browser#2873

Remove Brave specific header

Added check for member vars

Reverting header removal
Rewards automation moved this from Pending review to Completed Mar 15, 2019
Rewards Team automation moved this from Jason to Closed Mar 15, 2019
@jasonrsadler jasonrsadler reopened this Mar 15, 2019
Rewards automation moved this from Completed to In Progress Mar 15, 2019
@NejcZdovc NejcZdovc moved this from In Progress to P3, P4, & P5 Backlog in Rewards Mar 15, 2019
@jasonrsadler jasonrsadler moved this from Closed to Jason in Rewards Team Apr 17, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 17, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
2225577
@jasonrsadler jasonrsadler mentioned this issue Apr 17, 2019
Merged
9 of 19 tasks complete
@jasonrsadler jasonrsadler moved this from P3, P4, & P5 Backlog to Pending review in Rewards Apr 17, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 18, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
7ead54d
@NejcZdovc NejcZdovc moved this from Pending review to In Progress in Rewards Apr 18, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 19, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
d4651fd
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 23, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
0e7cf61
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 24, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
b49d7f8
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 26, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
cc974a5
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 29, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
c18df31
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 1, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
e3a68a5
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 2, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
5b0e4cd
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 2, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
ffeefc3
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 6, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Loading status checks…
b816340
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 21, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
b606559
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 23, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
e98e0a9
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 23, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Loading status checks…
3a1b0dc
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 25, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
31eae1b
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 29, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Loading status checks…
2d3258e
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 29, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Loading status checks…
3b07127
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 30, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Loading status checks…
758aede
@jasonrsadler jasonrsadler moved this from In Progress to Review/QA in Rewards May 30, 2019
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone May 30, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue May 30, 2019
Jason Sadler
Fixes brave/brave-browser#2873
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
e72a241
Rewards automation moved this from Review/QA to Done Jun 10, 2019
Rewards Team automation moved this from Jason to Closed Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA/No dev-concern feature/rewards priority/P5 release-notes/exclude
Projects
Rewards Team
Closed
Milestone
  0.68.x - Release
Linked pull requests

Successfully merging a pull request may close this issue.

Headers for grant captcha are now moved out of ledger
ID and Type are now sent with request headers on grant fetch
5 participants
@bridiver @rebron @NejcZdovc @jasonrsadler @LaurenWags
You can’t perform that action at this time.