Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching or opening pages through omnibox does not trigger events for user activity #28826

Closed
btlechowski opened this issue Mar 1, 2023 · 2 comments · Fixed by brave/brave-core#17490
Assignees
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android Tab QA/Yes release-notes/include

Comments

@btlechowski
Copy link

btlechowski commented Mar 1, 2023

The user activity is not increased as there is no events triggered when searching or opening pages through URL bar

Steps to reproduce

  1. Clean profile
  2. Enable rewards and ads
  3. Wait for unblinded tokens refill
  4. open a NTP
  5. Search for test through omnibox (url address bar)

Actual result

Events are triggered and User activity is not increased

Expected result

Events are triggered and User activity is increased

Issue reproduces how often

Easily reproduced

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Tablet
  • Android version: 11

Brave version

Brave v1.48.171 on Lenovo TB-8506FS (Android 11.0)

Also reproducible on
Brave v1.48.171 on Samsung Galaxy M21 (Android 12.0)

cc @tmancey @aseren

@btlechowski btlechowski changed the title Searching or opening pages through URL address bar does not trigger events for user activity Searching or opening pages through omnibox does not trigger events for user activity Mar 1, 2023
@aseren aseren self-assigned this Mar 1, 2023
@aseren aseren self-assigned this Mar 6, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 6, 2023
@tmancey tmancey added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 12, 2023
@brave-builds brave-builds added this to the 1.49.x - Release #3 milestone Mar 14, 2023
@kjozwiak
Copy link
Member

The above requires 1.49.124 or higher for 1.49.x verification 👍

@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 21, 2023
@btlechowski
Copy link
Author

Verification passed on Brave v1.49.126 on Lenovo TB-8506FS (Android 11.0)

Verified searching for test through omnibox increases user activity score (/*12*/ kTypedAndSelectedNonUrl)

14:00:35.613  V  [VERBOSE6:user_activity_manager.cc(49)] Triggered event: 15 (0:2:900 s)
14:00:35.614  V  [VERBOSE6:user_activity_manager.cc(49)] Triggered event: 12 (0.5:2:900 s)

Verified opening a page through omnibox increases user activity score /*14*/ kTypedUrl

14:02:00.697  V  [VERBOSE6:user_activity_manager.cc(49)] Triggered event: 15 (0.5:2:900 s)
14:02:00.697  V  [VERBOSE6:user_activity_manager.cc(49)] Triggered event: 14 (1:2:900 s)

Verified clicking on a link on a page increases user activity score /*06*/ kClickedLink

14:02:05.407  V  [VERBOSE6:user_activity_manager.cc(49)] Triggered event: 11 (1:2:900 s)
14:03:08.990  V  [VERBOSE6:user_activity_manager.cc(49)] Triggered event: 0B (1:2:900 s)
14:03:08.992  V  [VERBOSE6:user_activity_manager.cc(49)] Triggered event: 06 (2:2:900 s)

Verified ad was shown when threshold was reached

14:06:52.690  V  [VERBOSE1:eligible_inline_content_ads_v2.cc(36)] Get eligible inline content ads
14:06:52.818  V  [VERBOSE1:ads_impl.cc(380)] Successfully purged orphaned ad events for kInlineContentAd
14:06:52.825  V  [VERBOSE1:eligible_inline_content_ads_v2.cc(127)] 1 eligible ads out of 1 ads
14:06:52.826  V  [VERBOSE1:inline_content_ad.cc(67)] Opportunity arose to serve an inline content ad
14:06:52.826  V  [VERBOSE1:inline_content_ad_serving.cc(98)] Found 1 eligible ads
14:06:52.826  V  [VERBOSE1:inline_content_ad_serving.cc(133)] Served inline content ad:
                   placementId: 316b5df9-4611-428c-b9c8-16419b4ba4a6
                   creativeInstanceId: cbe9f40d-257f-429c-939c-39f3d05a0372
                   creativeSetId: 59ae2407-51ae-48f6-9d67-6ae234319181
                   campaignId: 07de7f05-ab32-4af0-a350-a1bce4427eac
                   advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
                   segment: untargeted
                   title: Staging - Inline Test 2
                   description: Fung Brave News Inline Display Ad - ios/android
                   imageUrl: https://pcdn.brave.com/brave-ads/468beb93-2458-5d3e-8d7b-bc1f387d2e9b.webp.pad
                   dimensions: 900x750
                   ctaText: Work at Brave
                   targetUrl: https://brave.com/careers
14:06:52.856  V  [VERBOSE3:inline_content_ad_event_served.cc(19)] Served inline content ad with placement id 316b5df9-4611-428c-b9c8-16419b4ba4a6 and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
14:06:52.868  V  [VERBOSE1:inline_content_ad_event_served.cc(28)] Successfully logged inline content ad served event
14:07:31.224  V  [VERBOSE3:inline_content_ad_event_viewed.cc(19)] Viewed inline content ad with placement id 5eabb3dd-93ae-4bfa-b59c-fd2282efa5bf and creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372
14:07:31.237  V  [VERBOSE6:inline_content_ad_event_viewed.cc(28)] Successfully logged inline content ad viewed event
14:07:31.254  V  [VERBOSE3:account.cc(177)] Successfully processed deposit for inline_content_ad with creative instance id cbe9f40d-257f-429c-939c-39f3d05a0372 and view valued at 0.01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants