Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards notifications are saved on shutdown only #2929

Closed
SergeyZhukovsky opened this issue Jan 11, 2019 · 0 comments
Closed

Rewards notifications are saved on shutdown only #2929

SergeyZhukovsky opened this issue Jan 11, 2019 · 0 comments

Comments

@SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Jan 11, 2019

Description

Notifications like grants, auto contribution status are not stored in storage until we shutdown the browser properly. We can miss them if there is a crash and etc

Steps to Reproduce

  1. Make sure you just received a notification above BAT icon
  2. Kill browser process
  3. Open browser again.

Actual result:

There is no notification

Expected result:

There is notification

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

any

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@SergeyZhukovsky SergeyZhukovsky added the bug label Jan 11, 2019
@SergeyZhukovsky SergeyZhukovsky self-assigned this Jan 11, 2019
@NejcZdovc NejcZdovc added this to the 0.61.x - Nightly milestone Jan 11, 2019
@NejcZdovc NejcZdovc added feature/rewards and removed bug labels Jan 11, 2019
@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Jan 11, 2019
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to Completed in Rewards Jan 11, 2019
@NejcZdovc NejcZdovc closed this Jan 11, 2019
@NejcZdovc NejcZdovc added the QA/No label Jan 11, 2019
@NejcZdovc NejcZdovc mentioned this issue Feb 1, 2019
10 of 18 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.