Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copyright needs to be with Brave and not Google #3289

Closed
simonhong opened this issue Feb 9, 2019 · 2 comments
Closed

Copyright needs to be with Brave and not Google #3289

simonhong opened this issue Feb 9, 2019 · 2 comments
Assignees
@simonhong
Labels
OS/Windows QA Pass-Win64 QA/Yes installer/omaha release-notes/exclude setup/installer
Milestone
0.60.x - Release ...

Comments

@simonhong
Copy link
Collaborator

@simonhong simonhong commented Feb 9, 2019

This issue is copied from brave/devops#563 to set milestone.

All Windows installers says Copyright Google.inc. This needs to be changed.

image
@simonhong simonhong self-assigned this Feb 9, 2019
@simonhong simonhong mentioned this issue Feb 9, 2019
Merged
@simonhong
Copy link
Collaborator Author

@simonhong simonhong commented Feb 9, 2019

Fixed by brave/omaha#23
@simonhong simonhong closed this Feb 9, 2019
This was referenced Feb 9, 2019
Merged
Merged
Merged
Merged
@btlechowski
Copy link
Collaborator

@btlechowski btlechowski commented Feb 14, 2019

Verification passed on

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

Files checked:

BraveBrowserBetaSetup.exe
BraveBrowserBetaSetup32.exe
BraveBrowserSilentBetaSetup.exe
BraveBrowserSilentBetaSetup32.exe
BraveBrowserStandaloneBetaSetup.exe
BraveBrowserStandaloneBetaSetup32.exe
BraveBrowserStandaloneSilentBetaSetup.exe
BraveBrowserStandaloneSilentBetaSetup32.exe

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Windows QA Pass-Win64 QA/Yes installer/omaha release-notes/exclude setup/installer
Projects
None yet
Milestone
  0.60.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

Update omaha to hide google copyright from installer(nightly)
3 participants
@rebron @simonhong @btlechowski
You can’t perform that action at this time.