Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark and pin icon behavior is not correct for top sites (on new tab page) #3347

Closed
btlechowski opened this issue Feb 13, 2019 · 5 comments

Comments

@btlechowski
Copy link
Collaborator

commented Feb 13, 2019

Follow up from #633

Test plan / Steps to Reproduce

  1. Clean install
  2. Open a page
  3. Open a new tab
  4. Hover over a top site

Actual result:

Not bookmarked top site has a bookmarked icon
Bookmarked top site has a not bookmarked icon
Bookmark icons are flipped

new tiles

Expected result:

bookmarked top site has bookmarked icon

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

cc @brave/legacy_qa @cezaraugusto

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Feb 14, 2019

The bookmark icon and unbookmarked icons are flipped. Unbookmarked icon shows filled dark colour but bookmarking it fills with white colour making it look like unfilled icon.

@rebron rebron added this to P5 Backlog in General Feb 14, 2019

@rebron rebron removed this from P5 Backlog in General Feb 14, 2019

@btlechowski btlechowski added the design label Feb 15, 2019

@LaurenWags

This comment has been minimized.

Copy link
Collaborator

commented Feb 15, 2019

Reproduced on macOS

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

@rebron rebron added this to Untriaged backlog in New Tab page Feb 21, 2019

@rossmoody rossmoody self-assigned this Feb 28, 2019

@rossmoody rossmoody added this to the 0.63.x - Nightly milestone Feb 28, 2019

@bsclifton bsclifton changed the title Mixed Bookmark icons on new tab top sites Icon behavior is not correct on new tab top sites Feb 28, 2019

@bsclifton bsclifton changed the title Icon behavior is not correct on new tab top sites Bookmark and pin icon behavior is not correct on new tab top sites Feb 28, 2019

@bsclifton bsclifton changed the title Bookmark and pin icon behavior is not correct on new tab top sites Bookmark and pin icon behavior is not correct for top sites (on new tab page) Feb 28, 2019

@rebron rebron moved this from Untriaged backlog to P1, P2 backlog in New Tab page Feb 28, 2019

@rebron rebron moved this from P1, P2 backlog to Completed in New Tab page Feb 28, 2019

@btlechowski

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 13, 2019

Verification passed on

Brave 0.63.4 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from the description. Also checked top sites pining.
Encountered top site bookmarking problems: #2971

Verified passed with

Brave 0.63.30 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

Verified STR from description.

Verification passed on

Brave 0.63.30 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Ubuntu 18.04 LTS

Used test plan from the description. Also checked top sites pining.

@GeetaSarvadnya

This comment has been minimized.

Copy link
Collaborator

commented Mar 21, 2019

Blocked and unable to test due to #3805

@rebron

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2019

@GeetaSarvadnya Can you try now? #3805 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.