Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix third-party detection in brave/ad-block #3535

Closed
bbondy opened this issue Mar 1, 2019 · 0 comments
Closed

Fix third-party detection in brave/ad-block #3535

bbondy opened this issue Mar 1, 2019 · 0 comments
Assignees
@bbondy
Labels
QA/No release-notes/exclude
Milestone
0.61.x - Release ...

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Mar 1, 2019 •
edited

Currently ad-block determines third party by sub-domain rules.
It should instead do eTLD+1 for this detection.
This makes it work more closely to uBlock and other ad-blocking libraries.
@bbondy bbondy self-assigned this Mar 1, 2019
This was referenced Mar 1, 2019
Merged
Merged
@bbondy bbondy added the QA/No label Mar 1, 2019
This was referenced Mar 1, 2019
Merged
Merged
@bbondy bbondy added this to the 0.61.x - Beta milestone Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA/No release-notes/exclude
Projects
None yet
Milestone
  0.61.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

Determine third-party status in Brave-Core
2 participants
@bbondy @kjozwiak
You can’t perform that action at this time.