Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons color should be contrast to the theme color #3555

Open
pvamshi opened this issue Mar 3, 2019 · 1 comment
Open

Icons color should be contrast to the theme color #3555

pvamshi opened this issue Mar 3, 2019 · 1 comment

Comments

@pvamshi
Copy link

@pvamshi pvamshi commented Mar 3, 2019

Description

The light theme icons color need to be changed according to theme. The disabled icon looks darker while the active icon is lighter ( which on lighter theme makes the effect reversed).

Steps to Reproduce

  1. Change default theme to a lighter theme
  2. Navigate to any website

Actual result:

This is how the icons look like on light theme
image

Expected result:

It should be in contrast to the theme similar to what it is in dark background
The same in dark theme
image

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 0.60.45 
Chromium: 72.0.3626.109 (Official Build)unknown (64-bit)
Revision | fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS | Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Not sure. Didnt check in dev builds

Website problems only:

Not related to website

Additional Information


@bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 4, 2019

cc: @petemill

@rebron rebron added this to Untriaged backlog in Front End Mar 5, 2019
@rebron rebron added the priority/P4 label Mar 8, 2019
@rebron rebron moved this from Untriaged backlog to P3 & P4 backlog in Front End Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Front End
  
P4 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.