Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out Composer UI Dynamic Token Background #35559

Closed
Douglashdaniel opened this issue Jan 24, 2024 · 1 comment · Fixed by brave/brave-core#21739
Closed

Build out Composer UI Dynamic Token Background #35559

Douglashdaniel opened this issue Jan 24, 2024 · 1 comment · Fixed by brave/brave-core#21739
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.64.x - Release

Comments

@Douglashdaniel
Copy link

Description

We need to build out a reusable background component that parses the dominant color of a tokens image and then use that color as the background in the new Composer UI

Screen.Recording.19.mov
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jan 24, 2024
@Douglashdaniel Douglashdaniel self-assigned this Jan 24, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Jan 24, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Jan 25, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.64.102 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
Revision c9343c77bd5dee3524fc45f89721ce0bf4c09b8d
OS Windows 11 Version 23H2 (Build 22631.3155)
  • Verified steps from issue description and brave/brave-core#21739
  • Verified dynamic token background changes on both Send and Swap tokens screen
35559.mp4

@LaurenWags LaurenWags mentioned this issue Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Dynamic Token Background brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds