Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clock and stats padding for right-to-left languages on the New Tab Page #3574

Closed
levi128 opened this issue Mar 5, 2019 · 9 comments
Closed

Comments

@levi128
Copy link

@levi128 levi128 commented Mar 5, 2019

Description

the widgets are Asymmetrical when i'm using the Hebrew language!
Fix?

Steps to Reproduce

  1. when i open the browser

Actual result:

https://imgur.com/CljFIsI
https://imgur.com/ZPck5r6
cljfisi

Expected result:

Reproduces how often:

Brave version (brave://version info) 0.60.47 Chromium: 72.0.3626.119

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@levi128
Copy link
Author

@levi128 levi128 commented Mar 5, 2019

https://imgur.com/MuoDWfF

here the photo!

@rebron
Copy link
Collaborator

@rebron rebron commented Mar 5, 2019

@levi128 What do you mean by asymmetrical? The font sizing of the clock (larger) versus the stats?

@levi128
Copy link
Author

@levi128 levi128 commented Mar 5, 2019

@levi128 What do you mean by asymmetrical? The font sizing of the clock (larger) versus the stats?

It's a bit too much on the sides .. the clock and the stats! moment. I'll send pictures. In English it's fine. But in Hebrew it's a bit out of the middle!

@levi128
Copy link
Author

@levi128 levi128 commented Mar 5, 2019

@levi128 What do you mean by asymmetrical? The font sizing of the clock (larger) versus the stats?

https://imgur.com/CljFIsI

https://imgur.com/ZPck5r6

The first one is in Hebrew.

The second English! See the differences?
Thanks for the help!

@rebron rebron changed the title a Bug? in brave Fix padding with clock and stats for NTP Hebrew locale Mar 5, 2019
@rebron
Copy link
Collaborator

@rebron rebron commented Mar 5, 2019

For Hebrew locale (probably effects Arabic too or rtl languages), need to add proper padding on right and left side for stats and clock. Both are flush to the window.
cc: @cezaraugusto @rossmoody

@rebron rebron added this to Untriaged backlog in New Tab page Mar 5, 2019
@rebron rebron added the priority/P4 label Mar 8, 2019
@rebron rebron moved this from Untriaged backlog to P3, P4 backlog in New Tab page Mar 11, 2019
@imptrx imptrx mentioned this issue May 17, 2019
0 of 9 tasks complete
imptrx added a commit to brave/brave-core that referenced this issue May 17, 2019
@cezaraugusto cezaraugusto added this to the 0.67.x - Nightly milestone May 17, 2019
@imptrx imptrx mentioned this issue May 17, 2019
2 of 28 tasks complete
pes10k added a commit to brave/brave-core that referenced this issue May 22, 2019
jdkuki added a commit to brave/brave-core that referenced this issue May 23, 2019
@rebron rebron moved this from P3, P4 backlog to Completed in New Tab page Jun 4, 2019
@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Jun 26, 2019

@imptrx does this require manual QA? if so, can you add a test plan and QA/Yes label? if not, can you mark as QA/No? thanks! 👍

@imptrx
Copy link

@imptrx imptrx commented Jun 26, 2019

@LaurenWags Here is the test plan!

Steps to check:

  1. Open brave in a RTL language
  2. Open a new tabs page

Assert:

  • Clock and Stats widget should not be flush with screen
@LaurenWags
Copy link
Collaborator

@LaurenWags LaurenWags commented Jun 26, 2019

awesome, thanks @imptrx 😄

@GeetaSarvadnya
Copy link
Collaborator

@GeetaSarvadnya GeetaSarvadnya commented Jul 18, 2019

Verification passed on

Brave 0.67.111 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Arabic:

image

Hebrew:

image

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

Hebrew:
image

Arabic::
image

Verified passed with

Brave 0.67.112 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Hebrew:
Screen Shot 2019-07-24 at 3 21 38 אח׳

Arabic:
Screen Shot ٢٠١٩-٠٧-٢٤ at ٣ ٢٢ ٣٢ م

@LaurenWags LaurenWags mentioned this issue Jul 19, 2019
147 of 157 tasks complete
@rebron rebron changed the title Fix padding with clock and stats for NTP Hebrew locale Fix padding with clock and stats for right-to-left languages on the New Tab Page Jul 24, 2019
@rebron rebron changed the title Fix padding with clock and stats for right-to-left languages on the New Tab Page Fix clock and stats padding for right-to-left languages on the New Tab Page Jul 24, 2019
@rebron rebron removed this from Completed in New Tab page Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants
You can’t perform that action at this time.