Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy issue in dialog confirming adding an extension from the Chrome Web Store #3620

Open
gueorgui opened this issue Mar 7, 2019 · 3 comments
Open

Comments

@gueorgui
Copy link

@gueorgui gueorgui commented Mar 7, 2019

Description

When adding an extension from the Chrome Web Store, the extension name in the confirmation dialog is corrupted. Instead of being Extension Name, it's instead Extension NameExtension NameGmail Checker.

Steps to Reproduce

  1. Navigate to an extension's page in the Chrome Web Site (ex: Notion)
  2. Click the "Add to Chrome" button
  3. Read the confirmation dialog

Actual result:

screenshot 2019-03-07 at 18 36 43

Expected result:

Text in confirmation dialog should read Add "Notion Web Clipper" anyway?

Reproduces how often:

Every time.

Brave version (brave://version info)

Brave 0.60.47 Chromium: 72.0.3626.119 (Official Build) (64-bit)
Revision 9a65993e2cde1b5797ec98da4cd9abcea464cd7b-refs/branch-heads/3626@{#876}
OS Mac OS X

Reproducible on current release:

Reproduces on both dev and beta builds.

Additional Information

My OS and Brave are both set to English (UK), but the issue still persists when setting English (US) as the top priority language in the Brave settings.

@rebron
Copy link
Collaborator

@rebron rebron commented Mar 14, 2019

hi @gueorgui.

We released an updated version 0.61.51 Chromium: 73.0.3683.75 this Tuesday (Official build). Can you check to see if it reproduces for you with that version, manually update via chrome://settings/help if not already on the current version?

I'm not seeing this happen on this version now.
Screen Shot 2019-03-14 at 1 20 25 PM

@gueorgui
Copy link
Author

@gueorgui gueorgui commented Mar 14, 2019

@rebron Still happening on the latest version!

Screenshot 2019-03-15 at 00 55 32

Brave 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X
@gueorgui
Copy link
Author

@gueorgui gueorgui commented Mar 15, 2019

@rebron It might be relevant that my OS locale is British English, and so is my browser's.

Screenshot 2019-03-15 at 01 06 27

Screenshot 2019-03-15 at 01 07 09

@rebron rebron added this to P5 Backlog in General Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
General
  
P5 Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.