Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest designs for pending transaction panel confirm and reject buttons #36343

Closed
josheleonard opened this issue Feb 23, 2024 · 1 comment · Fixed by brave/brave-core#22287

Comments

@josheleonard
Copy link

Description

Screenshot 2024-02-23 at 4 28 57 PM

Steps to Reproduce

  1. create a pending transaction
  2. observe the confirm and reject buttons

Actual result:

the buttons have a large border radius and have icons

Expected result:

the buttons have a smaller border radius and no icons

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.65.89 Chromium: 123.0.6312.58 (Official Build) beta (64-bit)
Revision 2975bd8d3905ed79de82dd9fa11b6e4019075dd6
OS Windows 11 Version 23H2 (Build 22631.3296)
  • Verified steps from issue description
  • Verified Confirm/Reject buttons have a bigger border radius and doesn't have any icons
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants