Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Earns While Notifications are Supressed #3651

jonathansampson opened this Issue Mar 11, 2019 · 2 comments


3 participants
Copy link

jonathansampson commented Mar 11, 2019


When notifications are disabled for the browser, ad notifications still register as having been displayed and the user is able to earn BAT in spite of never having seen a notification or ad.

Steps to Reproduce

  1. Enable Brave Rewards and Ads
  2. Visit Notifications & Settings in Windows Settings
  3. Disable notifications for Brave


Actual result:

The browser believes it is showing ad notifications from time to time.

Expected result:

The browser ceases to show notifications, or is aware that they aren't visible.

Reproduces how often:


Brave version (brave://version info)


Reproducible on current release:

Ads only enabled in Developer build at the moment.


This comment has been minimized.

Copy link

jonathansampson commented Mar 11, 2019

Originally tracked in #2548.

@jsecretan jsecretan added this to Untriaged Backlog in Rewards Mar 11, 2019

@jsecretan jsecretan moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards Mar 12, 2019

@tmancey tmancey moved this from P1 & P2 Backlog to Pending review in Rewards Mar 19, 2019

@tmancey tmancey moved this from Pending review to In Progress in Rewards Mar 19, 2019

@tmancey tmancey self-assigned this Mar 19, 2019


This comment has been minimized.

Copy link

tmancey commented Mar 20, 2019

This is possible on iOS/macOS using getNotificationSettingsWithCompletionHandler:, for further information see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.