Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter option to block instead of empty response #3749

Closed
bbondy opened this issue Mar 16, 2019 · 0 comments
Closed

Add a filter option to block instead of empty response #3749

bbondy opened this issue Mar 16, 2019 · 0 comments

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Mar 16, 2019

Description

Some websites respond better when you block explicitly instead of a 200 OK.
Once example is www.wsj.com videos.
Sending a 200 OK with empty content keeps doing the imasdk resopnse in a loop.
Instead adding code to always block it would be ideal.

Steps to Reproduce

  1. Go to www.wsj.com
  2. Play a video

Actual result:

Spins forever

Expected result:

Plays the video.

Reproduces how often:

Always

Brave version (brave://version info)

All currently released (0.61.x is on Release channel at the time of this writing)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? yes
  • Is the issue reproducible on the latest version of Chrome? no
@bbondy bbondy self-assigned this Mar 16, 2019
@bbondy bbondy added this to Untriaged / Incoming in Shields via automation Mar 16, 2019
@bbondy bbondy changed the title Add a filter option to block instead of empty response Fix wsj.com video playback by Adding a filter option to block instead of empty response Mar 19, 2019
Shields automation moved this from Untriaged / Incoming to Completed Mar 19, 2019
@bbondy bbondy changed the title Fix wsj.com video playback by Adding a filter option to block instead of empty response Add a filter option to block instead of empty response Mar 19, 2019
@bbondy bbondy reopened this Mar 19, 2019
Shields automation moved this from Completed to Untriaged / Incoming Mar 19, 2019
@bbondy bbondy added the QA/No label Mar 19, 2019
Shields automation moved this from Untriaged / Incoming to Completed Mar 19, 2019
@bbondy bbondy added this to the 0.63.x - Beta milestone Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Shields
  
Completed
Linked pull requests

Successfully merging a pull request may close this issue.

1 participant
You can’t perform that action at this time.