Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards verified status should be fetched from list value rather than from database #3780

Closed
jasonrsadler opened this issue Mar 19, 2019 · 2 comments

Comments

@jasonrsadler
Copy link

commented Mar 19, 2019

Description

If a user visits an unverified site that later becomes verified, that site will still show unverified for that user

Steps to Reproduce

  1. Enable Rewards clean profile
  2. Visit an unverified site and ensure place in publisher_info_db
  3. Quit Brave and modify site value in publisher_list to verified
  4. Restart Brave and go to site modified above

Actual result:

Site still shows as unverified

Expected result:

Site should show verified

Reproduces how often:

100%

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@jasonrsadler jasonrsadler added this to Untriaged Backlog in Rewards via automation Mar 19, 2019

@jsecretan jsecretan moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards Mar 19, 2019

@NejcZdovc NejcZdovc self-assigned this Mar 19, 2019

@NejcZdovc NejcZdovc added this to Nejc in Rewards Team Mar 19, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 25, 2019

@NejcZdovc NejcZdovc moved this from P1 & P2 Backlog to In Progress in Rewards Mar 26, 2019

@NejcZdovc NejcZdovc referenced this issue Mar 26, 2019

Merged

Get verified state from the list #2078

7 of 19 tasks complete

NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 26, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 26, 2019

@NejcZdovc

This comment has been minimized.

Copy link
Member

commented Apr 5, 2019

blocked on #4025 and #3953

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 8, 2019

@NejcZdovc NejcZdovc added the QA/Yes label Apr 8, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 8, 2019

@NejcZdovc NejcZdovc added this to the 0.65.x - Nightly milestone Apr 8, 2019

@NejcZdovc NejcZdovc moved this from In Progress to Pending review in Rewards Apr 8, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 9, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 10, 2019

Rewards automation moved this from Pending review to Completed Apr 10, 2019

Rewards Team automation moved this from Nejc to Closed Apr 10, 2019

pilgrim-brave added a commit to brave/brave-core that referenced this issue Apr 16, 2019

@LaurenWags

This comment has been minimized.

Copy link
Collaborator

commented May 21, 2019

Verified passed with

Brave 0.65.98 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • Verified test plan from brave/brave-core#2078
  • Also verified test plan steps using both YouTube and Twitch channels. When YT and Twitch channels are not verified, the generic YT or Twitch icon was used as appropriate (both the site specific favicon and verified icons no longer displayed on brave://rewards or panel).

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.65.107 Chromium: 75.0.3770.38 (Official Build) beta (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.