Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux app icons look blurry on 100% DPI #3788

Open
srirambv opened this issue Mar 19, 2019 · 2 comments
Open

Linux app icons look blurry on 100% DPI #3788

srirambv opened this issue Mar 19, 2019 · 2 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Mar 19, 2019

Description

Linux app icons look blurry on 100% DPI

Steps to Reproduce

  1. Install all brave channels
  2. pin them as favourites
  3. Unpin them as its too bad to look at

Actual result:

Brave icons on favourites bar
image

Brave icons in apps listing
image

Brave icons vs stock icons
image

Expected result:

Same as stock app icons not blurry

Reproduces how often:

Easy

Device display info

image

cc: @brave/uplift-approvers @bradleyrichter @rossmoody to decide priority of the issue

@rebron rebron added this to Untriaged Backlog in General Mar 21, 2019
@rebron rebron added the priority/P4 label Mar 22, 2019
@rebron rebron moved this from Untriaged Backlog to P4 Backlog in General Mar 26, 2019
@rossmoody
Copy link
Contributor

@rossmoody rossmoody commented Mar 29, 2019

I've done a bunch of research on this and I'm a little stumped. A few things I can say for certain:

  1. Linux is getting served the correct icons at the correct sizes which is 128px. brave/brave-core@980fda8#diff-ca3b8b8f7388a32c28d344375ceca455R12
  2. The icons aren't pixelated at 128px. Scaling them down should not result in the pixelation we're seeing here.
  3. The icons can't be served larger than 128px.
  4. When I pull the icons that are getting served to Linux out of the build and look at them, they don't look like what's posted here. None of the available icons that can be served could produce that result from what I can tell. This leads me to think it's a cache issue or the system is searching for an icon it can't find so it's using some artifact in memory.

This is also sorta interesting because it seems like it's not having the issue with Release but it is with the builds. @simonhong might be worth pinging for a quick look on this as I saw he setup a lot of the early Linux build stuff.

Screen Shot on 2019-03-28 at 17:25:21

A few things thing I came across when researching that might be worth pursuing would be below. I think otherwise, we should find another person with Gnome 3 Ubuntu who can recreate this so we know it's not isolated.

https://gitlab.gnome.org/GNOME/mutter/issues/135
https://askubuntu.com/questions/722708/how-do-i-refresh-the-icon-cache

@fmarier
Copy link
Member

@fmarier fmarier commented Sep 27, 2019

I'm running GNOME 3 at 100% DPI and I don't these blurry icons in the sidebar:
Capture d’écran de 2019-09-27 14-17-52
or in the applications panel:
Capture d’écran de 2019-09-27 14-18-47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
General
  
P4 Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.