Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JS blocking notifications with details (NoScript) #38

Closed
bbondy opened this issue Dec 27, 2017 · 2 comments
Closed

Add JS blocking notifications with details (NoScript) #38

bbondy opened this issue Dec 27, 2017 · 2 comments
Assignees
@yrliou
Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Dec 27, 2017 •
edited

The front end needs a way to get details of the JS resources which are blocked.
@bbondy bbondy added this to the Milestone 1: To be able to open source the repo milestone Dec 27, 2017
@bbondy bbondy self-assigned this Dec 27, 2017
@bbondy bbondy assigned yrliou and unassigned bbondy Mar 1, 2018
@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Milestone 2: To offer Installable and updatable builds Mar 19, 2018
@bbondy bbondy changed the title Add JS blocking notifications with details Add JS blocking notifications with details (NoScript) Mar 19, 2018
@bbondy
Copy link
Member Author

@bbondy bbondy commented Mar 19, 2018

Duping to brave/unofficial-snap#6
@bbondy bbondy closed this Mar 19, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Add JS blocking details
Verified
This commit was signed with a verified signature.
bbondy Brian R. Bondy
GPG key ID: C063402E6BCBEFAD Learn about signing commits
1a5b750 
Fix #38
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #38 from brave/x86_ffmpeg_linux_fix
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
4476258 
fix for x86 linux ffmpeg issue
@bbondy bbondy modified the milestones: Milestone 2: To offer Installable and updatable builds, Releasable builds Jun 13, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 21, 2018 •
edited by kjozwiak

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
@kjozwiak kjozwiak added QA Pass-macOS and removed QA/Yes labels Sep 25, 2018
@yrliou yrliou added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
QA Pass-Linux QA Pass-Win64 QA Pass-macOS QA/Yes
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@bbondy @kjozwiak @yrliou @srirambv @btlechowski
You can’t perform that action at this time.