Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads enabled for unsupported regions #3967

Closed
srirambv opened this issue Apr 1, 2019 · 11 comments

Comments

@srirambv
Copy link
Collaborator

commented Apr 1, 2019

Description

While verifying #2562, found even if device on unsupported region, Ads get enabled.

Steps to Reproduce

  1. Set VPN to a unsupported region
  2. Launch a clean profile of beta
  3. Enable rewards
  4. Open rewards setting, Sorry, Ads are not available in your region message pops up for a second and then ads settings get enabled

Actual result:

Ads enabled for unsupported regions

Expected result:

Unavailable message should persist and ads should not be enabled. Only for supported regions should be enabled

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.63.28 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes on beta and dev. Not checked on Nightly

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    N/A

Additional Information

cc: @tmancey @jsecretan set priority to P2, please change if required
@brave/legacy_qa to verify on other platforms as well

@tmancey

This comment has been minimized.

Copy link
Collaborator

commented Apr 1, 2019

@ryanml do you know of any recent changes which may have caused this please?

@ryanml

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

@tmancey I have not made any changes related to this since: brave/brave-core#1941 - I can do some investigation on this one though 👍

@tmancey

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2019

@ryanml This could be related to Chromium returning en_US for non supported regions, let me check this first and I will then get back to you if that is ok?

However this does not explain why the UI displays for a brief moment.

@ryanml

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

@tmancey sounds good. Double checking the logic in place is all sound but yeah just seems that the wrong value is showing for region

@btlechowski

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

I am located in Poland and Ads are enabled. I don't see any ads though.

Brave 0.63.30 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

image

@tmancey

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

@btlechowski Ads are not available at this time in Poland, an unavailable message should be shown and ads should not be enabled, thanks

@tmancey tmancey moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards Apr 4, 2019

@GeetaSarvadnya

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

I am located in India Ads are disabled

image

Brave 0.64.36 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

@tmancey tmancey moved this from P1 & P2 Backlog to In Progress in Rewards Apr 9, 2019

@tmancey tmancey self-assigned this Apr 9, 2019

@GeetaSarvadnya

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

I am not getting Sorry, Ads are not available in your region message for the region India. I was seeing the message on 0.64.36 version, but not now. I am not getting this message in any of the Dev and Beta versions.

Brave 0.64.40 Chromium: 74.0.3729.61 (Official Build) dev (64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Windows 10 OS Build 17134.523
Brave 0.63.34 Chromium: 74.0.3729.40 (Official Build) beta (64-bit)
Revision 278d6a0d856d8314f36fb9a68b6e1d85cd0d14e7-refs/branch-heads/3729@{#470}
OS Windows 10 OS Build 17134.523

tmancey added a commit to brave/brave-core that referenced this issue Apr 17, 2019

@jsecretan jsecretan added priority/P1 and removed priority/P2 labels Apr 17, 2019

tmancey added a commit to brave/brave-core that referenced this issue Apr 17, 2019

tmancey added a commit to brave/brave-core that referenced this issue Apr 17, 2019

tmancey added a commit to brave/brave-core that referenced this issue Apr 17, 2019

tmancey added a commit to brave/brave-core that referenced this issue Apr 17, 2019

Rewards automation moved this from In Progress to Completed Apr 17, 2019

Rewards Team automation moved this from Others to Closed Apr 17, 2019

@tmancey tmancey moved this from Completed to Pending review in Rewards Apr 17, 2019

@tmancey tmancey moved this from Pending review to Waiting uplift in Rewards Apr 17, 2019

@srirambv

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 22, 2019

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Linux
  • Setting VPN to supported region and OS locale changed doesn't enable ads
    image
  • Setting VPN and OS locale to supported region shows ads as expected

Verified passed with

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Mac OS X
  • Verified test plan from brave/brave-core#2232
  • Verified did not see 'Sorry' message when IP and Region were set appropriately for included regions (US, Can, UK, FR, DE). When 'Sorry' message was not displayed, verified was able to access UI (settings, etc).
  • Verified did see 'Sorry' message when IP and Region were set for non-included regions (Australia, Sweden, etc). When 'Sorry' message was displayed, was unable to access Ads UI (settings, etc).
    Screen Shot 2019-04-22 at 16 36 06

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523
  • Verified test plan from brave/brave-core#2232

  • Verified did not see 'Sorry' message when IP and Region were set appropriately for included regions (US, Can, UK, FR, DE). When 'Sorry' message was not displayed, verified was able to access UI (settings, etc).

image

  • Have done testing on all combinations of IP, Region, and Locale in #4172 (comment)
@muro886

This comment has been minimized.

Copy link

commented May 13, 2019

I am in Turkey please enable ads for Turkey.

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.706
@lyquocnam

This comment has been minimized.

Copy link

commented Jul 18, 2019

i am in Vietnam, please enable ads for Vietnam.

Brave 0.66.99 Chromium: 75.0.3770.100 (Official Build) (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.