Skip to content

/ brave-browser

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better download logic for DAT files #40

Closed
bbondy opened this issue Dec 28, 2017 · 2 comments
Closed

Add better download logic for DAT files #40

bbondy opened this issue Dec 28, 2017 · 2 comments
Assignees
@emerick
Labels
QA/No
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Dec 28, 2017

Currently it just downloads on each run.
It should use etags and conditionally download and check only on certain time intervals. See browser-laptop for reference.
@bbondy bbondy added this to the Milestone 1: To be able to open source the repo milestone Dec 28, 2017
@bbondy
Copy link
Member Author

@bbondy bbondy commented Dec 31, 2017

Possibly by wrapping dat files as extensions instead.
@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Milestone 2: To offer Installable and updatable builds Mar 19, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #40 from brave/x86_linux_package_sym_deps
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
91bc123 
X86 linux package sym deps
@bbondy
Copy link
Member Author

@bbondy bbondy commented Jun 2, 2018

Fixed here and in commits after this:
brave/brave-core@581b1b4
@bbondy bbondy closed this Jun 2, 2018
@bbondy bbondy modified the milestones: Milestone 2: To offer Installable and updatable builds, Releasable builds Jun 13, 2018
@bbondy bbondy added the QA/No label Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
QA/No
Projects
None yet
Milestone
  0.55.x - Release ...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bbondy @emerick
You can’t perform that action at this time.