Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Ad Rewards settings panel #4008

Closed
mandar-brave opened this issue Apr 4, 2019 · 6 comments

Comments

@mandar-brave
Copy link
Collaborator

commented Apr 4, 2019

References:
Currently the uncashed tokens are sent to the server, against a wallet ID, every week.
On the 5th of each month, Brave Rewards resets the estimated earnings counter to zero.

Issue:
Because the uncashed tokens are not in sync (weekly redemption vs. one time monthly payment), when the counter resets to zero, the user may perceive that they lost earned tokens.

Fix:
When the clock gets to the 5th of the month, the user should see the tokens that were not redeemed yet.

  • so grant will show all uncashed tokens redeemed
  • and the user will see value for tokens not yet redeemed (instead of 0)

Prioritizing it as a P1 since it feels like earned BAT was lost.

@jsecretan @evq @NejcZdovc @tmancey

@mandar-brave mandar-brave added this to Untriaged Backlog in Rewards via automation Apr 4, 2019

@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards Apr 5, 2019

@tmancey tmancey added this to the 0.65.x - Nightly milestone Apr 5, 2019

@tmancey tmancey moved this from P1 & P2 Backlog to In Progress in Rewards Apr 5, 2019

@tmancey tmancey moved this from In Progress to P1 & P2 Backlog in Rewards Apr 5, 2019

@JoelMon

This comment has been minimized.

Copy link

commented Apr 5, 2019

I don't see 0 but I do see a lot less then I am supposed to have. Every time I open the program the number drops so it's not only a problem with the date. https://streamable.com/ekvlv

@NejcZdovc NejcZdovc added this to Others in Rewards Team Apr 8, 2019

@tmancey

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

I don't see 0 but I do see a lot less then I am supposed to have. Every time I open the program the number drops so it's not only a problem with the date. https://streamable.com/ekvlv

@JoelMon could you please record a longer video showing the balance continuing to drop so I can investigate further as I am unable to reproduce the issue, thanks

@JoelMon

This comment has been minimized.

Copy link

commented Apr 10, 2019

I don't see 0 but I do see a lot less then I am supposed to have. Every time I open the program the number drops so it's not only a problem with the date. https://streamable.com/ekvlv

@JoelMon could you please record a longer video showing the balance continuing to drop so I can investigate further as I am unable to reproduce the issue, thanks

For the past few releases I've noticed that the balance has not dropped.

I'm using Version 0.64.40 Chromium: 74.0.3729.61 (Official Build) dev (64-bit) and I haven't noticed any drop. I'll continue to keep my eyes on it and let you know if I see it dropping again, hopefully this time around I'll record it at a better quality. 👋

@jsecretan jsecretan added priority/P2 and removed priority/P1 labels Apr 10, 2019

@jsecretan

This comment has been minimized.

Copy link
Collaborator

commented Apr 12, 2019

So, discussing with @mandar-brave and @davidtemkin, we want to:

  1. Change "Current earnings this month (Estimated") to "Estimated earnings this cycle"
  2. On 12:01 on the 5th of every month, reset the notifications and earnings counters to include both uncashed "receipts" and earnings starting from the 1st.
@jsecretan

This comment has been minimized.

Copy link
Collaborator

commented Apr 12, 2019

Because cashed in and un-cashed in confirmations are not currently connected, and because we want to avoid drastic changes to the schema, @tmancey has suggested a way where we know to determine what was not yet cashed in:
If there are 10 transactions in the history and we have 7 unblinded payment tokens, we know that the first 3 transactions were cashed-in and that the last 7 transactions had not been cashed-in.

@tmancey tmancey moved this from P1 & P2 Backlog to In Progress in Rewards Apr 16, 2019

@tmancey tmancey referenced this issue Apr 18, 2019

Merged

Fix the Ad Rewards settings panel #2269

9 of 28 tasks complete

@tmancey tmancey moved this from In Progress to Pending review in Rewards Apr 18, 2019

Rewards automation moved this from Pending review to Completed Apr 18, 2019

Rewards Team automation moved this from Others to Closed Apr 18, 2019

tmancey added a commit to brave/brave-core that referenced this issue Apr 18, 2019

tmancey added a commit to brave/brave-core that referenced this issue Apr 18, 2019

tmancey added a commit to brave/brave-core that referenced this issue Apr 18, 2019

tmancey added a commit to brave/brave-core that referenced this issue Apr 18, 2019

@LaurenWags

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

Verified passed with

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • Verified with test plan provided by @tmancey

Verification passed on

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Verification PASSED on Ubuntu 18.04.2 LTS x64 using the following build:

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Verification passed on

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.