Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads Rewards Grants - expiration date in UI - follow up to 4042 #4169

Closed
LaurenWags opened this issue Apr 18, 2019 · 2 comments

Comments

@LaurenWags
Copy link
Collaborator

commented Apr 18, 2019

Description

Ad grants still displaying expiration date on UI from both brave://rewards page and panel when viewing the grants list (which contains both UGP and Ad grants).

Steps to Reproduce

  1. Claim an Ad grant. Note, on the "It's your lucky day" screen there isn't a date.
  2. Navigate to brave://rewards or open panel.
  3. Click on 'Grants' button.

Actual result:

Expiration date is displayed:
Screen Shot 2019-04-18 at 7 39 32 PM

Expected result:

No expiration date (like on "It's your lucky day" screen:
Screen Shot 2019-04-18 at 7 38 45 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta(64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? unsure
  • Can you reproduce this issue with the nightly channel? unsure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @mandar-brave @NejcZdovc @jsecretan

@btlechowski

This comment has been minimized.

Copy link
Collaborator

commented Apr 19, 2019

Reproduced on

Brave 0.63.45 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

image

@jsecretan jsecretan moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards Apr 19, 2019

@NejcZdovc NejcZdovc self-assigned this Apr 24, 2019

@NejcZdovc NejcZdovc moved this from P1 & P2 Backlog to In Progress in Rewards Apr 24, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 24, 2019

@NejcZdovc NejcZdovc added this to Nejc in Rewards Team Apr 24, 2019

@NejcZdovc NejcZdovc referenced this issue Apr 24, 2019

Merged

Removes date from ads grants in the wallet #2337

7 of 28 tasks complete

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 25, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 25, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 25, 2019

@NejcZdovc NejcZdovc moved this from In Progress to Pending review in Rewards Apr 25, 2019

@NejcZdovc NejcZdovc added this to the 0.66.x - Nightly milestone Apr 25, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 26, 2019

NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 26, 2019

@NejcZdovc NejcZdovc moved this from Pending review to Waiting uplift in Rewards Apr 26, 2019

@NejcZdovc NejcZdovc moved this from Waiting uplift to Pending review in Rewards Apr 26, 2019

Rewards automation moved this from Pending review to Completed Apr 27, 2019

Rewards Team automation moved this from Nejc to Closed Apr 27, 2019

@NejcZdovc NejcZdovc moved this from Completed to Waiting uplift in Rewards Apr 27, 2019

@GeetaSarvadnya

This comment has been minimized.

Copy link
Collaborator

commented May 6, 2019

Verification passed on

Brave 0.63.52 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

image
image
image

Verified passed with

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • Verified test plan from brave/brave-core#2337
  • Verified Ad grants do not display expiration dates
    Screen Shot 2019-05-06 at 10 08 54 AM
    Screen Shot 2019-05-06 at 10 09 09 AM
    Screen Shot 2019-05-06 at 10 09 37 AM
  • Verified UGP grants still display expiration dates:
    Screen Shot 2019-05-06 at 10 10 32 AM
    Screen Shot 2019-05-06 at 10 11 12 AM

Verification PASSED on Ubuntu 18.04.2 LTS x64 using the following build:

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Screen Shot 2019-05-06 at 1 32 04 PM

Screen Shot 2019-05-06 at 1 33 35 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.