Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcut to expand Search bar in Settings #4178

Open
Brave-Matt opened this issue Apr 19, 2019 · 2 comments
Open

Add keyboard shortcut to expand Search bar in Settings #4178

Brave-Matt opened this issue Apr 19, 2019 · 2 comments

Comments

@Brave-Matt
Copy link
Collaborator

@Brave-Matt Brave-Matt commented Apr 19, 2019

Description

There's currently no way to expand/move the focus to the search bar on the Settings page other than clicking on the Search icon -- with one exception.

When you first land on Settings, hitting esc will expand the search bar and move keyboard focus to it so you can start typing. Hitting esc again will close the menu which I believe is intended. However, you can only hit esc to expand/collapse the search bar once, after-which hitting esc (or anything) no longer performs this function.

Further, using the esc method above breaks if anything else is selected on the page.

Example 1 (macOS): Hit cmd + , to bring up settings, hit esc to expand, then to collapse, then hit it again -- esc no longer expands search
settingssearch

Steps to Reproduce

  1. Go to Settings
  2. Hit esc to expand search
  3. Tap esc again to close search
  4. Try using esc again to open or move focus to Settings search

Actual result:

See gif above

Expected result:

Search should expand/collapse every time esc or some other keyboard shortcut is pressed.

Reproduces how often:

Always

Brave version (brave://version info)

Beta v63.50 and up

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@rebron
Copy link
Collaborator

@rebron rebron commented Apr 26, 2019

note to check accessibility.

@onmyouji
Copy link

@onmyouji onmyouji commented Apr 28, 2019

I wish you can bring back the old search bar on top-center of the page. The current placement of the search icon on right end is very out of place and not user friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Settings
P5 backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.