Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix confusing content settings names #42
Closed
Labels
Milestone
Comments
bbondy
referenced
this issue
in brave/brave-core
Dec 28, 2017
Antimuon changes for: https://github.com/brave/brave/issues/42
bbondy
referenced
this issue
in brave/brave-extension
Dec 28, 2017
Fix https://github.com/brave/brave/issues/42 Requires: brave/brave-core#11
cezaraugusto
pushed a commit
that referenced
this issue
May 15, 2018
Add tooling to localize Brave extension with Transifex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently use 'allow' for content setting of ad-block which is confusing because you're allowing the ad-block of ads.
Instead change to content settings name of 'ads' and allow or block them.
Also it's an issue if you toggle on and off in sequence for top level shields, it clears the saved previous values of the sub-shield settings. This needs to be stored separately.