Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser history not work well sometimes #4294

Closed
KayacChang opened this issue May 3, 2019 · 2 comments
Closed

Browser history not work well sometimes #4294

KayacChang opened this issue May 3, 2019 · 2 comments

Comments

@KayacChang
Copy link

@KayacChang KayacChang commented May 3, 2019

Description

The problem happened when I testing the browser history api.

My test is open website with specify URL params,
and check if the userToken is empty, then direct back to GameHall.
else, pushState( null, null, url.origin) to clean the URL params.
and add popstate event to check if the user click the back button,
he will direct back to GameHall.

Generally, it's work fine.
But there's sometimes not work correctly
when I click back and forward button multiple times
but it's work well in Chrome.

Brave version (brave://version info)

Version 0.63.48 Chromium: 74.0.3729.108 (Official Build) (64-bit)

@rebron
Copy link
Collaborator

@rebron rebron commented May 10, 2019

@egg734631 Can you submit some sample code to reproduce this?

@bsclifton
Copy link
Member

@bsclifton bsclifton commented May 20, 2019

Since there isn't anything actionable- I'm going to close this issue. But please do re-open and share more information if you have it.

@egg734631 it would be great if you had an example (ex: something on jsbin.com or your personal site) that can reproduce for everybody

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.