NPM Run Create_dist options are not working

[davidfritsche17]

Description

npm run create_dist release --skip_signing --debug_build=false --official_build=false
None of the flags/options seem to work for me.

Skip_Signing
At first I thought it was just the Skip_signing that was not working since it always tries to sign at the end of the build. I have built many times(at least a dozen full builds) and the signing always is attempted.

Debug_build
However, now after re-running the build at least a dozen times with Debug on and off, I do not believe this option is working as well. The release build with or without debug false or true is always the same size. When running the build (brave.exe) after building with debug_build=false, the debug information appears when there is an error.

My main issue here is the installer (Brave_installer and mini_installer) created is 1.3 GB. Doing a POC and need to see this much smaller, or find a way to use the Dist folder and create my own installer. I can do this, but something seems incomplete here and I cannot run the browser from the Dist folder. Running the Brave.exe from Dist folder gives - "The application has failed to start because its side-by-side configuration is incorrect". Would LOVE some advice here as well. (but I digress).

It does not appear the options to this are working.

Steps to Reproduce

1. npm run create_dist release --skip_signing --debug_build=false --official_build=false
   Run various combinations with these options. Does not appear to matter. I have also tries --signtool=false. Same result, but i don't think that's the right syntax.

Actual result:

Results are the same regardless of the options. Easiest thing to spot is the signtool is run regardless of the options. My expectation is the debug_build=false would produce a smaller installer. That seems obvious to me...but I could be wrong.

Expected result:

Runing the command with different options should give different results.

Reproduces how often:

Always

Brave version (brave://version info)

Windows
66.48
have also tried on 63.48 (matched the released browser version)

Version/Channel Information:

Have not attempted channels.

Other Additional Information:

Miscellaneous Information:

[bbondy]

Try adding -- just after create_dist and it should work! :)
npm run create_dist -- release --skip_signing --debug_build=false --official_build=false

[davidfritsche17]

thank you. Will try. Is this the right place to ask dev questions? Or is there another forum? I am in the Brave Community forum, but so far no luck getting questions answered.

[bbondy]

It's ok to ask them here :)