Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chromium text in cert error page #4332

Open
srirambv opened this issue May 7, 2019 · 1 comment
Open

Fix Chromium text in cert error page #4332

srirambv opened this issue May 7, 2019 · 1 comment
Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes release-notes/include
Projects

Comments

@srirambv
Copy link
Contributor

srirambv commented May 7, 2019

Description

Fix Chromium text in cert error page

Steps to Reproduce

  1. Visit https://revoked.badssl.com/
  2. Click on advanced
  3. Shows Chromium

Actual result:

image

Expected result:

Should not have any Chromium branding on cert error page

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the dev channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    N/A
  • Does the issue resolve itself when disabling Brave Rewards?
    N/A
  • Is the issue reproducible on the latest version of Chrome?
    No. Chrome has Google branding

Miscellaneous Information:

@srirambv srirambv added about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages QA/Yes release-notes/include QA/Test-Plan-Specified labels May 7, 2019
@btlechowski
Copy link
Collaborator

Reproduced on

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

image

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 10, 2019
@rebron rebron added this to P4 backlog in Front End May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Front End
  
P4 backlog
Development

No branches or pull requests

3 participants